Bug#754441: RFS: gmastermind.app/0.6-1 [ITP] -- GNUstep based Mastermind (TM) clone

[Yavor Doganov <yavor@gnu.org>]

Riley Baird wrote:
> > I don't think that this was the author's intention.
> 
> > From a legal point of view, GPL 2.0 does mean GPL 2.0 only, but I
> > agree that this probably wasn't the author's intention.

Well, it could be argued if this little notice in README carries more
legal weight than the intent expressed in the source files (the notice
does not follow the recommended form and gpl.txt is missing)...

We (pkg-gnustep) had an inititive 6 or 7 years ago to re-check the
licenses of all GNUstep packages as the license of the GNUstep core
libraries was upgraded to LGPLv3+ (the summary is still here:
https://wiki.debian.org/DebianGNUstep/TODO).  Unsurprisingly, many of
the supposed GPLv2-only apps were licensed as such unintentionally by
their authors, or were presumed by us to be GPLv2-only based on
assumptions very similar to yours.  GMastermind is much more likely to
be GPL-2+ than GPL-2; I am quite certain about that.  It's best to
clarify though, so that you could sleep well.

> To be sure of this, though, I'd have to get confirmation from all of
> the contributors; writing to upstream wouldn't be enough. Should I
> try to do this?

I think it would be enough to contact the GAP folks, they can reach
the others if necessary.

> > You'd better add the conditional so that the package can be easily
> > rebuilt for debugging without source modifications

> Done

But now the package is always built with debug=yes.  You need to
define the variable conditionally, like

ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
optim := debug=yes
endif

> > override_dh_link:
> > 	mv $(d_app)/usr/bin/GMastermind $(d_app)/usr/games
> > 	rm -rf $(d_app)/usr/bin
> > 	mv $(d_app)$(GNUSTEP_SYSTEM_APPS)/*.app/Resources \
> > 	  $(d_app)/usr/share/GNUstep/GMastermind.app
> > 	dh_link /usr/share/GNUstep/GMastermind.app \
> > 	  $(GNUSTEP_SYSTEM_APPS)/GMastermind.app/Resources
> 
> Done. (I've added some mkdir -p lines in there so that it compiles.)

$ GMastermind 
2014-07-13 17:41:15.743 GMastermind[21255] Bad application class '(null)' specified

And the icon is missing.  This is because
/usr/share/GNUstep/GMastermind.app contains the Resources directory;
it should contain the files that are located there instead:

-     mkdir -p $(d_app)/usr/share/GNUstep/GMastermind.app
+     mkdir -p $(d_app)/usr/share/GNUstep

> I've just put the new package is on mentors

Thanks; no further remarks from me.  Good luck in your sponsor quest.