--- Begin Message ---
On Fri, Jun 13, 2014 at 10:30 PM, Dale Mellor <dale@rdmp.org> wrote:
> On Sun, 2014-05-25 at 16:57 +0100, Dale Mellor wrote:
>> > >On Fri, May 9, 2014 at 12:05 AM, Dale Mellor
>> > > <dale_mellor@users.sourceforge.net> wrote:
>> > >
>> > >
>> > > Package: sponsorship-requests
>> > > Severity: normal
>> > >
>> > > Dear mentors,
>> > >
>> > > I am looking for a sponsor for my package "mcron"
>> > >
>> > > Package name : mcron
>> > > Version : 1.0.8-1
>> > > Upstream Author : Dale Mellor <dale_mellor@users.sourceforge.net
>> > > URL : http://www.gnu.org/software/mcron
>> > > License : GPL3
>> > > Section : utils
>> > >
>> > > It builds those binary packages:
>> > >
>> > > mcron - Guile-based program for running jobs at regular times
>> > >
>> > > To access further information about this package, please visit the following URL:
>> > >
>> > > http://mentors.debian.net/package/mcron
>> > >
>> > >
>> > > Alternatively, one can download the package with dget using this command:
>> > >
>> > > dget -x http://mentors.debian.net/debian/pool/main/m/mcron/mcron_1.0.8-1.dsc
>> > >
>> > > More information about mcron can be obtained from http://www.gnu.org/software/mcron.
>> > >
>>
>> > On Sat, 2014-05-10 at 21:53 -0700, Vincent Cheng wrote:
>> >
>> > Here's a quick review of your package:
>> >
>> > - what's the purpose of debian/mcron@GUILE_SITE@/ ? Please remove it.
>> > - in general, please be more verbose in debian/changelog. Stuff like
>> > bumping standards version, adding new build-deps, or adding/removing
>> > patches should all be mentioned.
>> > - latest Standards version is 3.9.5, not 3.9.4.
>> > - debian/make-test.patch is unnecessary, just include an empty
>> > override target in debian/rules (it's as simple as
>> > "override_dh_auto_test:")
>> > - debian/man-page.patch is the wrong approach as well; you should
>> > instead build-dep on help2man and generate the manpage post-build
>> > (instead of patching it in), e.g. by overriding dh_install or
>> > dh_installman in d/rules
>> >
>> > Regards,
>> > Vincent
>>
>> Hello,
>>
>> I have addressed these issues with a new up-stream release, and the
>> package I would now like to get into Debian is mcron 1.0.8-1 (the links
>> above have been modified).
>>
>> Thanks,
>> Dale
>>
>
> Bump. Not sure what the etiquette is, but I'm still holding out for
> this to be uploaded; its delay is holding up the move from
> guile-1.8->guile-2.0 in testing.
>
A few follow-up comments:
- d/changelog should mention things like bumping dh compat level, or
Standards-Version in d/control
- missing (DEP-3) patch header for debian/patches/make-clean.patch
- I'm not sure why you renamed debian/mcron.manpages ->
debian/mcron.manpage, because the former is preferred according to
dh_installman(1), although I guess it checks for either one so the
manpage still gets installed in the end
Looks fine otherwise, so built, signed, and uploaded; thanks for your
contribution to Debian!
Regards,
Vincent
--- End Message ---