[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#751534: RFS: crunch/3.6-1 [ITP] -- tool for creating wordlist



Control: tags -1 + moreinfo

* Marcio de Souza Oliveira <m.desouza20@gmail.com>, 2014-06-13, 17:53:
http://mentors.debian.net/debian/pool/main/c/crunch/crunch_3.6-1.dsc

Let me see:

Section: misc

Perhaps it should be “Section: text”?

Crunch is a wordlist generator where you can specify a standard character set or any set of characters to be used in generating the wordlists. The word list are created through combination and

s/list/lists/
And is it “wordlist” or “word list”?

This program supports numbers and symbols, upper and lower case characters separately and unicode.

Probably should be s/unicode/Unicode/.

Description: Added missing hyphen at line 75

Surely it's not very important that this is line 75?
And this patch is not adding any hyphen.

Description: Sudo removes the Makefile,

Did you mean “Remove sudo from the makefile”?
It would be nice to have this fixed upstream. (But if upstream doesn't like it, it's not end of the world.)

fix permissions charset.lst file

That part should be upstreamed, too. Although other files might need permission fixes, too.

prevents the installation file COPYNG.

Typo: COPYNG -> COPYING
But I wouldn't patch upstream makefile for this; instead, I'd remove the file in debian/rules.

In general, I prefer having every independent change in a separate patch, even when the changes are to the same file.

Have you forwarded debian/patches/fix_sourcecode upstream?
“fix_spelling” might be a better name for this than “fix_sourcecode”.

Copyright: 2004  ? <mimayin@aciiid.ath.cx>

What's up with this question mark?

License: GPL-2.0
This package is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This is inconsistent. The short name says it's GPLv2, but the license text says it's GPLv2+.

Incorrect information in the copyright file is a show-stopped, so I'm tagging the bug +moreinfo.

The upstream didn't provide a changelog.The changelog was file

Missing space between “changelog.” and “The”.
visit the URLs below if you want to confirm all informations:

“information” is a mass noun.
s/all informations/all the information/, I suppose.

Why is README.source shipped in the *binary* package? :-)

--
Jakub Wilk


Reply to: