[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#748831: RFS: crashme/2.7-1 [ITA]



Control: owner -1 !

* Dariusz Dwornikowski <dariusz.dwornikowski@cs.put.poznan.pl>, 2014-05-21, 08:07:
   dget -x http://mentors.debian.net/debian/pool/main/c/crashme/crashme_2.7-1.dsc
[...]
 * Copyright changed to DEP-5

This is not an accurate description of changes to the copyright file. The original copyright file was already in the DEP-5 format.

 * New maintainer (Closes: #739083)

Did you get any reply from George?

 * Hardening added

That's not an accurate description of the change you did either. (Although enabled hardening might be a side effect of this change.)

Why is override_dh_auto_build commented in debian/rules? If this code is not supposed to be run, then remove it.

Why do you set CFLAGS in debian/rules?

 * Spelling patch refreshed

Please forward the patch upstream. There's more typos that you might want to fix:

$ codespell --skip '*.patch'
./crashme.txt:26: seperate  ==> separate
./crashme.txt:77: enviroment  ==> environment
./crashme.html:147: exersize  ==> exercise
./crashme.html:272: seperate  ==> separate

 * Bump standards to 3.9.5

Did it require any changes to packaging?

 * Created manpage for pddet binary

I'm sorry to say that, but this manpage is not helpful. I read it twice, and still have no idea what is this program supposed to do.

 * d/rules updated to clean cleanly

If you listed files to remove in debian/clean, you could avoid the override in debian/rules.

--
Jakub Wilk


Reply to: