[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#748674: RFS: ipmitool/1.8.14-1 ITA



Hello Vincent,


Am Montag, den 19.05.2014, 16:31 -0700 schrieb Vincent Cheng:
> Control: tag -1 + moreinfo
> 
> On Mon, May 19, 2014 at 7:37 AM, Jörg Frings-Fürst
> <debian@jff-webhosting.net> wrote:
> > Package: sponsorship-requests
> > Severity: normal
> >
> >   Dear mentors,
> >
> >   I am looking for a sponsor for my package "ipmitool"
> >
> >  * Package name    : ipmitool
[...]
> 
> Please be more verbose/descriptive here, i.e. something like:
> - Fix FTBFS on kfreebsd (Closes: #725476)
> - Include bmcautoconf.sh script (Closes: #627041)
> ...etc.
> 
done

> Bugs that were fixed in an earlier upstream release (like #708387)
> should be closed manually by sending mail to 708387-done@bugs.d.o with
> the correct Version: header set (so that they're marked as fixed in
> the correct version(s)).
removed fixed bugs from changelog and closed them via -done@bugs.d.o.

> >   * Bumps compat to 9
> >   * New maintainer ( Closes: #748487 )
> 
> - debian/copyright: line 67 seems to be out of place (move to line 64?)
> - This is entirely up to you, but you could avoid
> possible-gpl-code-linked-with-openssl entirely if you chose to license
> debian/* under GPL-2+ with the openssl exception clause (instead of
> just plain GPL-2+). Also, as debian/* is the only thing that's
> GPL-licensed in the entire package, you could also just use the same
> license as the rest of upstream's source (3-clause BSD). Assuming you
> deliberately chose to license your packaging as GPL-2+, just be
> careful of including any non-trivial patches in debian/patches/*, as
> that could cause you to run into conflict with
> possible-gpl-code-linked-with-openssl.
Ok. I've set set debian/* also under BSD-3-clauses

> - A lot of your patches have incomplete DEP-3 headers (it looks like
> you've just copied and pasted from a template). Don't forget to
> forward your patches upstream if possible.
I've already mailed with the upstream - maintainer and asked how he
wants to get the patches. Therefor some headers are incomplete.

Incomplete DEP-3 header removed.

> - If you're going to install systemd service files, please build-dep
> on dh-systemd and put "dh $@ --with systemd" in debian/rules (AFAIK
> that injects some Debian+systemd-specific integration stuff into your
> maintainer scripts). [1]
done

> - debian/dirs and debian/README.source are both redundant (the latter
> because you use source format "3.0 (quilt)").
removed

> - lintian:
> W: ipmitool: manpage-has-errors-from-man
> usr/share/man/man1/ipmitool.1.gz 1037: warning [p 13, 4.0i]: can't
> break line
Patched with a heavy heart.

Uploaded to mentors[1]. Ticket for alioth is out.

> Regards,
> Vincent


Thanks,
Jörg


[1]
http://mentors.debian.net/debian/pool/main/i/ipmitool/ipmitool_1.8.14-1.dsc

-- 
pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8  EBCB 422B 44B0 BE58 1B6E
pgp Key: BE581B6E
CAcert Key S/N: 0E:D4:56

Jörg Frings-Fürst
D-54526 Niederkail

IRC: j_f-f@freenode.net
     j_f-f@oftc.net




Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: