Bug#747476: RFS: mcron/1.0.7-1

[Vincent Cheng <vcheng@debian.org>]

Control: tag -1 + moreinfo

On Fri, May 9, 2014 at 12:05 AM, Dale Mellor
<dale_mellor@users.sourceforge.net> wrote:
>
>
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "mcron"
>
>  Package name    : mcron
>  Version         : 1.0.7-1
>  Upstream Author : Dale Mellor <dale_mellor@users.sourceforge.net
>  URL             : http://www.gnu.org/software/mcron
>  License         : GPL3
>  Section         : utils
>
> It builds those binary packages:
>
>   mcron - Guile-based program for running jobs at regular times
>
> To access further information about this package, please visit the following URL:
>
> http://mentors.debian.net/package/mcron
>
>
> Alternatively, one can download the package with dget using this command:
>
>   dget -x http://mentors.debian.net/debian/pool/main/m/mcron/mcron_1.0.7-1.dsc
>
> More information about mcron can be obtained from http://www.gnu.org/software/mcron.
>
> Changes since the last upload:
>
>    * New upstream release.
>
>    * Run on top of guile-2.0 (was guile-1.8; fix brought in from upstream).
>      Closes: #746006.
>
>    * Fix ftbfs.  Closes: #641625.

Here's a quick review of your package:

- what's the purpose of debian/mcron@GUILE_SITE@/ ? Please remove it.
- in general, please be more verbose in debian/changelog. Stuff like
bumping standards version, adding new build-deps, or adding/removing
patches should all be mentioned.
- latest Standards version is 3.9.5, not 3.9.4.
- debian/make-test.patch is unnecessary, just include an empty
override target in debian/rules (it's as simple as
"override_dh_auto_test:")
- debian/man-page.patch is the wrong approach as well; you should
instead build-dep on help2man and generate the manpage post-build
(instead of patching it in), e.g. by overriding dh_install or
dh_installman in d/rules

Regards,
Vincent