[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#738596: DD for IP2Location Debian Package



Hi Kim,

sorry for it taking a while to answer.

> Is the package alright for submission?
>
> Our team would like to fix the changes if required.

I had another look at the package.
Most of the lintian warnings are still there. Overriding them is not
ok, unless there you a good reason, and you should explain what it is.
The purpose of lintian is to warning you about things that do not meet
the quality standard for Debian.

Lets's go though the list here:
http://mentors.debian.net/package/ip2location-c

* binary-file-built-without-LFS-support
is this a false positive? if so why? or does it not apply to
libip2location6? if so why?

* no-symbols-control-file
do not override this: being your package a library, it should use
symbol file. If you did not add them, do not hide it. I am ok with
uploading it without symbol files though, as it is not a strict
requirement

* package-file-is-executable
- debian/changelog
- debian/control
* binary-control-field-duplicates-source
- field "section" in package libip2location6
These 2 above need fixing

* duplicate-short-description
- libip2location-dev libip2location6
needs fixing. you can append "(development files)" to the description
of  libip2location-dev

* configure-generated-file-in-source
need fixing

* debian-watch-may-check-gpg-signature
would be nice to address, but is not a strict requirement, so I can
upload the package even this is not addressed. However, do not
override it.

* source-contains-prebuilt-binary
this needs to be fixed. No binary files should be included, everything
must be built from source.

Thanks,
Ludovico


Reply to: