Bug#745777: RFS: ipad-charge/0~20131118.c82b032-1 [ITP] -- USB charging control utility to charge an Apple device
Hi Benny,
I am not a DD, I cannot sponsor your package but here are some
comments:
Since it is your initial upload, the version should be -1, you bump
the number only when you *release* a new package. Merge all the
changes into 1.1-1 release.
Other things to fix:
- set homepage field in d/control to github project page
- standards should be 3.9.5
- make the package depend on debhelper >= 9 in d/control
- when upstream releases on github, you can prepere a watch file,
something like that should be sufficient:
version=3
https://github.com/mkorenkov/ipad_charge/releases .*/archive/v(\d[\d\.]+)\.tar\.gz
- in d/copyright you did not add years to Files: *
- patches are not described according to DEP-3 [1]
- what about udev rules ? are they installed ?
- did you check your package with pbuilder and/or piuparts ?
We can review the package once more, when you fix.
[1] http://dep.debian.net/deps/dep3/
--
Dariusz Dwornikowski,
Institute of Computing Science, Poznań University of Technology
www.cs.put.poznan.pl/ddwornikowski/
room 2.7.2 BTiCW | tel. +48 61 665 29 41
Reply to: