[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#740543: RFS: eggdrop/1.6.21-1 [ITA #698272]



Hi Vincent,

Thanks for your comments again.

On Sun, 20 Apr 2014 01:33:17 -0700
Vincent Cheng <vcheng@debian.org> wrote:

> 
> - Your package FTBFS with pbuilder (full build log attached):
> 
> checking for Tcl library... not found

Fixed.

According to http://eggwiki.org/Bugs/Tcl8.6 , eggdrop versions >=1.6.20
have no particular bugs with tcl8.6, so I use it instead of 8.5.

> - According to debian/changelog, eggdrop was split into two separate
> binary packages (an additional -data package) as of 1.6.16-3, so as
> per Policy 7.6.1 [1], consider adding "Breaks: eggdrop (<< 1.6.16-3)"
> and "Replaces: eggdrop (<< 1.6.16-3)" relationships to your
> eggdrop-data binary package, otherwise dpkg will error out on updates
> from eggdrop << 1.6.16-3 to the current eggdrop package. This would
> usually qualify as a RC bug, but since 1.6.16-3 was released about 10
> years ago, you could possibly get away with not doing this (I don't
> think piuparts.debian.org tests package upgrades from 10 years
> back...)

True, same comment and drop solution was suggested here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698599#12

So to avoid any further confusion I add the Breaks+Replaces <<1.6.16-3.

> - debian/copyright: please give src/rfc1459.c some kind of license
> name on line 40. Also, the current header in that file isn't really a
> license...if at all possible, I'd suggest adding the license of the
> corresponding source file from ircd-hybrid into debian/copyright.
> 

I listed rfc1459.c as the original ircd-hybrid 5.3 match.c license
(GPL-1+) with the current rfc1459.c header as a comment.

I believe (and hope) that the package is now correct and incremented the
version to 1.6.21-2 so that there is no confusion with the different -1
attempts.

You can find it here :
  http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc

PS: Lintian reports error debian-watch-file-pubkey-file-is-missing but
it's a lintian bug now fixed (#736711)

Regards,
-- 
Cédric


Reply to: