Hi Vincent,
Am Sonntag, den 20.04.2014, 00:20 -0700 schrieb Vincent Cheng:
> Hi Jörg,
>
> Please don't forget to cc your RFS bug (#744045).
>
> On Sun, Apr 13, 2014 at 7:31 AM, Jörg Frings-Fürst
> <debian@jff-webhosting.net> wrote:
> > Hallo,
> >
[...]
> > Am Samstag, den 12.04.2014, 01:12 -0700 schrieb Vincent Cheng:
> >> Control: tag -1 + moreinfo
> >>
> >> On Wed, Apr 9, 2014 at 7:17 AM, Jörg Frings-Fürst
> >> <debian@jff-webhosting.net> wrote:
> >> > Package: sponsorship-requests
> >> > Severity: normal [important for RC bugs, wishlist for new packages]
> >> >
> > [...]
>
> Here's a laundry list of things that can be improved in your packaging:
>
> - debian/copyright should contain per-file license information (if
> this was a NEW package, it would get rejected by ftpmasters for
> failing this), e.g. not all files are under GPLv2; some are public
> domain, like xsd/examples/cxx/parser/hello/driver.cxx). I suggest
> using DEP-5 [1] to ease the task of documenting this, but free-form
> debian/copyright is still ok as long as everything is documented. You
> can also take advantage of licensecheck (from the devscripts package),
> but you'll still have to manually check the source.
I have debian/copyright completely revised and all source - files
checked for the license.
> - collapse your debian/changelog entries into a single entry; I'd
> suggest versioning your current package as 3.3.0.2-1, leaving the
> "+dep" out
done
> - your watch file is broken:
>
> $ uscan --report-status
> Processing watchfile line for package xsd...
> Newest version on remote site is 3.3.0-2+, local version is 3.3.0.2+dep
> xsd: remote site does not even have current version
corrected
> - remove Vcs-Arch from debian/control (see Policy 5.6.26 [2] for what
> it's actually supposed to be used for)
I have no access to alioth. So I have the source saved on lauchpad.net
and the VCS - Entries point to this archive.
> - (pedantic) removing the unnecessary quilt build-dep and running
> wrap-and-sort to have the build-deps listed in alphabetical order
> would be nice
done
> - (pedantic) I'd suggest not overriding lintian tags that are actually
> valid (no-upstream-changelog, debian-watch-may-check-gpg-signature);
> you can safely just ignore those tags instead
no-upstream-changelog and debian-watch-may-check-gpg-signature removed
> - (pedantic) debian/rules: compress (gzip) your installed manpage and
> changelog (or use dh_install{man,docs} which would do that for you,
> instead of a single override_dh_auto_install target)
I have removed some unnecessary lines
> Also, is there a timeline on when you plan on tackling the issues in
> debian/TODO (i.e. are you waiting for some changes to be made
> upstream, or is it just lack of time that's hindering you for now,
> etc.)?
My opinion was the lib* take into separate packages with the coming
upstream version. But all lib* come without any install function . So
I've delete the TODO file.
The new revision can be found on [1].
> Regards,
> Vincent
>
[...]
Thanks for your work and Happy Eastern
Jörg
[1] https://mentors.debian.net/package/xsd
--
pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E
pgp Key: BE581B6E
CAcert Key S/N: 0E:D4:56
Jörg Frings-Fürst
54526 Niederkail
Attachment:
signature.asc
Description: This is a digitally signed message part