Bug#745135: RFS: mariadb-10.0/10.0.10-1 [ITP] -- Latest version of worlds most popular non-Oracle database
Hello Tobias,
Thanks for looking into this. My comments:
2014-04-18 15:12 GMT+03:00 Tobias Frost <tobi@coldtobi.de>:
> Hallo Otto,
>
> (disclaimer: I cannot sponsor it, I'm not a DD)
You still help me improve the quality of the package and mentor me
mentally, so thanks anyway!
> I did only take a look a the mentors interface, especially at the
> lintian section. It seems there are several things to be fixed:
I fixed some of the issues and pushed to git, see changes at
http://anonscm.debian.org/gitweb/?p=pkg-mysql/mariadb-10.0.git;a=log
Considering that MariaDB 5.5, MySQL 5.5 and MySQL 5.6 in Debian all
have a long list of Lintian issues, I think it is a bit too demanding
if all Lintian issues should be addressed, but of course it would be
nice to have as many as possible fixed.
> W outdated-autotools-helper-file -- looks like that dh-autoreconf or
> autotools-dev would like to be your friends.
Autotools is not used. These files seems to be just upstream cruft
left over, so I added a override with this comment.
> Please also the linitan errors, eg dir-or-file-in-var-run or
I removed that dir. I haven't checked with upstream it it is OK, but
obviously this one must be removed and later re-introduced as a mkdir
line in the server startup script or similar.
> missing-dependency-on-libc
Fixed.
> (There are many other information errors that are easy to fix)
>From my point of view all the low hanging things are done. Any help
with nailing the remaining issues is very appreciated.
> For the overriden linitian warnings: Most of those should be fixed
> instead of overriden: binary-without-manpage
> command-with-path-in-maintainer-script manpage-has-errors-from-man
> If you cannot fix them now, don't override them.
Are you sure? To me all these non-actionable warnings generate a lot
of noise and hides issues I could actually address. Although when I
look at http://lintian.debian.org/full/pkg-mysql-maint@lists.alioth.debian.org.html#mysql-5.5_5.5.35+dfsg-2
and http://lintian.debian.org/full/pkg-mysql-maint@lists.alioth.debian.org.html#mysql-5.6_5.6.16-1~exp1
they seem to have all these spelling errors and manpage warnings etc
not overridden. Maybe I should indeed remove those overrides...
> Generally, if you override linitian, please do document *why* in the
> overrides.
I've now added some more comment lines into the lintian-overrides.
Some of this packaging is inherited from years back, so as time passes
I'll review the need for old patches and overrides and the like, but I
do want to have some progress before I invest a lot more of my time
into this package. Having a sponsor waiting and promising to upload if
I work hard enough would be very encouraging..
> Stopping here, as it makes no sense to review the code if there are
> still lintian *errors*
I have now found a solution to all errors now and there are only three
"harmless" warnings left.
> BTW, to me it seems that mariadb-5.5 itself would have use of some
> overhaul. There are e.g 4 errors and 8 warnings for it; at least one of
> the errors would qualify RC (if linitian is right on this, of course;
> but then they should be overriden)
Thanks for reminding. I reviewed them now and fixed some I had a
solution to. The changes will be included in the 5.5.37 upload.
--
Check out our blog at http://seravo.fi/blog
and follow @ottokekalainen
Reply to: