Control: tags -1 - moreinfo * James McDonald <james@jamesmcdonald.com>, 2014-04-10, 20:46:
An unintended side-effect of passing CFLAGS to make is that now warnings (except -Wformat) are no longer enabled. :/Perhaps upstream could fix their makefile, so that they honour CFLAGS from environment? It's a bit odd that they do it with CPPFLAGS and LDFLAGS, but not with CFLAGS.I have added a simple patch to fix this for the time being.
Great. Now that all *FLAGS from environment are honoured, there should be need to pass CFLAGS explicitly in debian/rules; just calling dh_auto_build should be enough.
You could avoid the dh_auto_clean override by adding “changelog” to debian/clean.
I have modified the package to rename the binary, manual page and .desktop file to openbsd-cwm, and added a README.Debian to note this change. I haven't modified the contents of the man pages. Should I do so?
I think so.
If so, just where the binary name is referenced, or globally?
The former.The default locking program is “xlock”. But we don't have “xlock” in Debian, so it's probably not the best choice…
The default terminal emulator is “xterm”. I think that “x-terminal-emulator” (see policy §11.8.3) would be a better choice. (But if you choose to keep xterm as the default, then please add “xterm” to Recommends. I didn't have xterm installed, and not being able to spawn a terminal was rather unpleasant experience.)
Was the priority of the x-window-manager alternative computed in accordance with Policy §11.8.4? (I don't think it was, but I could be wrong.)
-- Jakub Wilk