Bug#736973: nftables RFS resend
On 12 April 2014 09:29, Vincent Cheng <vcheng@debian.org> wrote:
> A few blocking issues:
>
> - debian/copyright is missing copyright holders + license of e.g.
> header files in include/linux/*
Fixed.
> - your package FTBFS (full pbuilder build log attached):
>
> checking for nft_rule_alloc in -lnftables... no
> configure: error: No suitable version of libnftables found
>
Fixed. I messed up the git pkg repo.
> Some non-blocking / pedantic issues:
>
> - AFAIK uscan/devscripts will check for
> debian/upstream/signing-key.asc, not .pgp, but then again, I'm not
> sure if there's consensus yet on where exactly to put upstream's key
> in the first place...
Fixed.
> - please pass --disable-silent-rules to ./configure so that compiler
> flags show up in the build logs (and so the logs are actually useful
> for some of Debian's automated tools, e.g. the buildd log scanner
> [1]). This also goes for libnftnl as well.
Can't fix in nftables because the build system. I will talk to
upstream about this.
Fixed in libnftnl for the next release (or should I release a
1.0.0+git20140122-2 package?).
> - I wouldn't override any lintian tags that are actually valid issues
> (hyphen-used-as-minus-sign); it's fine if you decide to just ignore
> them
>
Fixed.
I just uploaded to mentors the fixed version.
Thanks a lot for your comments Vincent.
regards.
--
Arturo Borrero González
Reply to: