Bug#742077: RFS: vcmi/0.95-1 [ITP]
* Johannes Schauer <j.schauer@email.de>, 2014-03-19, 06:31:
[I don't intend to sponsor this package. Sorry!]
dont worry, I'm happy for any help that can improve my packaging! :)
All right… :-P
I wouldn't repack the .orig.tar just to remove debian/. If you're using
the "3.0 (quilt)" format, dpkg-source removes upstream debian/ for you
at unpack time.
But if you choose to repack .orig.tar anyway, then please consider using
.xz for compression, to save a few megabytes. :-)
codespell(1) reports tons of typos. You might want to report them
upstream.
I didn't have patients to wait until cppcheck(1) completes, but it
reports at least:
[lib/CObjectHandler.h:898]: (style) Class 'IQuestObject' is unsafe, 'IQuestObject::quest' can leak by wrong usage.
[AI/FuzzyLite/FuzzyException.cpp:76]: (error) Dangerous usage of c_str(). The value returned by c_str() is invalid after this call.
It seems that the AUTHORS file is not utf8 but either windows-1250 or
iso-8859-2
Indeed.
--
Jakub Wilk
Reply to: