[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#738683: RFS: hexchat/2.9.6.1-1 [ITP]



Control: tag -1 + moreinfo

On Tue, Feb 11, 2014 at 2:43 PM, sney <drubo@drubo.net> wrote:
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "hexchat"

Comments:

- debian/copyright is incomplete: e.g.
 src/dirent/dirent-win32.h: Toni Ronkko, Expat
 intl/*.{c,h}: Free Software Foundation, Inc., LGPL-2.1+

I find licensecheck (from devscripts) to be a very useful tool to dig
through license headers in each file. Of course, it's not perfect, so
you still have to do some manual work. Anyways, there may be more
undocumented license headers, I just gave a few examples above.

- debian/control:

Package: hexchat-common
Architecture: all
Recommends: xchat

                      ^  shouldn't that be "hexchat"?

Also, please consider using "wrap-and-sort -s" to sort your
build-depends and depends field alphabetically and one per line; it
makes reviewing diffs to debian/control much easier to read later on.

- debian/changelog: collapse all unreleased entries into a single
entry (i.e. just retain your 2.9.6.1-1 entry and delete everything
else)

- debian/paste.txt: remove this

Regards,
Vincent


Reply to: