Re: RFS: read-edid/3.0.1-2
Hi,
Okay I did not read your code carefully. You need to handle a matrix
of 4 cases, where only 2 were shown in your code. The actual counter
example was: -DCLASSICBUILD=YES and powerpc. Please handle powerpc
(any non-x86 actually) in your if statement. sorry for the confusion
with kfreebsd-*
Thanks.
On Fri, Feb 14, 2014 at 1:20 PM, Dariusz Dwornikowski
<dariusz.dwornikowski@cs.put.poznan.pl> wrote:
> And I think it is set. It is the "else" clause. ksfreebsd-amd64 will be
> caught there and -DI2CBUILD=NO -DCLASSICBUILD=YES will be set.
>
> I think I am a little confused now.
>
>
> On 14 February 2014 13:12, Mathieu Malaterre <mathieu.malaterre@gmail.com>
> wrote:
>>
>> In which case you would need to have -DCLASSICBUILD=ON on
>> ksfreebsd-amd64 if I understand the previous exchange correctly.
>>
>> On Fri, Feb 14, 2014 at 1:07 PM, Dariusz Dwornikowski
>> <dariusz.dwornikowski@cs.put.poznan.pl> wrote:
>> > I did not include the line, I take DEB_HOST_ARCH from:
>> > DEB_HOST_ARCH := $(shell dpkg-architecture -qDEB_HOST_ARCH)
>> >
>> > So on ksfreebsd-amd64 it will give me: ksfreebsd-amd64, so DI2CBUILD
>> > would
>> > be set to NO. Or is it not ?
>> >
>> >
>> > On 14 February 2014 12:59, Mathieu Malaterre
>> > <mathieu.malaterre@gmail.com>
>> > wrote:
>> >>
>> >> On Fri, Feb 14, 2014 at 12:55 PM, Dariusz Dwornikowski
>> >> <dariusz.dwornikowski@cs.put.poznan.pl> wrote:
>> >> > Ok I created such code in rules:
>> >> >
>> >> > override_dh_auto_configure:
>> >> > ifeq ($(DEB_HOST_ARCH), $(filter $(DEB_HOST_ARCH),amd64 i386))
>> >> > dh_auto_configure -- -DCLASSICBUILD=YES -DI2CBUILD=YES
>> >> > else
>> >> > dh_auto_configure -- -DI2CBUILD=NO -DCLASSICBUILD=YES
>> >> > endif
>> >> >
>> >> > Can somebody review it for me ? I checked and it works on amd64 and
>> >> > i386.
>> >>
>> >> I don't think this works for -say- kfreebsd-amd64, which would require
>> >> -DI2CBUILD=OFF
>> >> You need to handle each option independantly, depending on arch
>> >>
>> >> 2cts
>> >
>> >
>> >
>> >
>> > --
>> > Pozdrawiam,
>> > Dariusz Dwornikowski, Assistant
>> > Institute of Computing Science, Poznań University of Technology
>> > www.cs.put.poznan.pl/ddwornikowski/
>> > room 2.7.2 BTiCW | tel. +48 61 665 29 41
>> >
>>
>>
>>
>> --
>> Mathieu
>
>
>
>
> --
> Pozdrawiam,
> Dariusz Dwornikowski, Assistant
> Institute of Computing Science, Poznań University of Technology
> www.cs.put.poznan.pl/ddwornikowski/
> room 2.7.2 BTiCW | tel. +48 61 665 29 41
>
--
Mathieu
Reply to: