Bug#733578: RFS: hwinfo/20.1-1 [ITA] -- Hardware identification system
On Sun, Jan 19, 2014 at 3:47 AM, Sebastien Badia <seb@sebian.fr> wrote:
> Hi Vincent,
>
> Thank you very much !
>
> According your comments, I've just fixed and uploaded a new version on mentors.
>
> If you have any time to re-review this package, I really appreciate.
> https://mentors.debian.net/package/hwinfo
Comments:
- You're using source format 3.0 (quilt) already, so drop the
extraneous build-dep on quilt in d/control. You can also drop
debian/README.source.
- Why do you depend directly on libx86emu1? ${shlibs:Depends} should
take care of that for you.
- If you don't use upstream's tarball / upstream doesn't provide
tarballs, you should have a get-orig-source target in debian/rules
(Policy 4.9), which for this package would just run
debian/get-tarball.sh when invoked.
> I still have a lintian warning about « hardening-no-relro »,
> but I don't known how to fix it :-/
Your build system isn't using the build flags that dpkg-buildflags
specifies. You get this for free with common build systems like
autotools, but your package looks like it has nothing more than a
hand-written makefile, so you may need to modify it to work with
dpkg-buildflags.
Regards,
Vincent
Reply to: