[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]



Control: tag -1 moreinfo

On Fri, Jan 17, 2014 at 9:40 AM, Joseph Herlant <herlantj@gmail.com> wrote:
> Hi Vincent,
>
> Thanks for the suggestion for the usage of the Breaks keyword. I personally
> prefer to do as the gnome-shell-extensions do which is adding "gnome-shell
> (>= 3.8), gnome-shell (<< 3.9)" to the package. I'll update the package
> accordingly for the next release.

Sure, that works too. Don't forget to fix that in the current package
you have on mentors (as well as a few other things which I'll mention
below).

> For the integration of the gnome-shell-extensions, it was my first idea, but
> as the author explained on the Github's readme:
> "Until recently it was just an GNOME Shell extension, with latest release it
> became an app. It was necessary change to make ground for coming features, a
> todo list for instance. However, it no longer will be possible to distribute
> it via extensions.gnome.org, we need to figure out packaging and it will
> take a few months..."
>
> So I followed the author's mind and created an independent package.
>
>
> Anyway, I'm using it (installed using the package I've done) on 2 computer
> for quite some times now without issue.

How is this different from gnome-shell-timer, which is already
packaged in debian?

Anyways, here's a quick review of your package:

debian/control:
- Vcs-Browser is present, but not Vcs-Git? Also, ideally your
packaging would be hosted on alioth, although I don't think there's
anything in Policy that prohibits it from being hosted elsewhere.
- Standards version needs a bump to 3.9.5
- Why "Architecture: any" if there aren't any arch-specific files in
your package?
- Description synopsis (the short one-liner) should be <60 chars (Policy 3.4.1)

debian/README.source is empty, just remove it

debian/watch is missing

> PS: I added you to the "to" reply because I'm not sure you've subscribed to
> the bug. My apologies if you receive this mail twice.

No need to send it to me directly or cc me; sending mail to any bug
against sponsorship-requests also gets sent to the debian-mentors
mailing list, which I'm subscribed to. I don't particularly care about
this though, so feel free to cc me all you want.

Regards,
Vincent


Reply to: