Re: Bug#706820: RFS: mytop/1.9.1-1 ITA

[Werner Detter <werner@aloah-from-hell.de>]

Hi,

>>  * URL             : http://www.mysqlfanboy.com/mytop/ 
> 
> Unreachable from here currently, when have you reached that site the
> last time?

Yesterday as I started with the package yesterday and downloaded the
sources from there.

> Uh fun to review ... I find the naming of patch 10 a bit confusing or is this
> a pun I don't get currently?

That was a typo - was supposed to be "quit" instead of "quilt" :) Fixed
in latest uploaded package.

> How many of these patches have been proposed for upstream inclusion?

Well, all patches that have been addressed in the new package where
transferred from the "old package" and recreated an reapplied against
the latest sources. Patches that have not been recreated were fixed
in the new upstream release already or they were not appropriate any
more.

> Beside that I wonder if it would make sense to rely more on the dh_ tools
> instead of self crafted stuff like
> 
>         cd debian/tmp ; find . -type f ! -path "./DEBIAN*" -print0 | xargs -0 md5sum | sed -e 's!\./!!' > DEBIAN/md5sums
>         chmod 644 debian/tmp/DEBIAN/md5sums
>         dpkg-gencontrol -isp
>         chown -R root.root debian/tmp
>         chmod -R go=rX debian/tmp
>         dpkg --build debian/tmp ..
>         dh_perl
>         dh_md5sums
> 
> It doesn't even make sense to generate the md5sum file first by hand, create
> the package itself and then run dh_perl and dh_md5sums. dh_perl even throws
> out a visible message that someting is wrong. And yes that is wrong.

Right, "the hand stuff" still comes from the "old package in Debian", I
just added "dh_perl and dh_md5sums" by hand as i wanted to get rid of
the "handmade stuff" but didn't finish.

> The naming of the mytop.example file is also a bit unlucky since that would
> also match dh_installexamples, and yes I see that's currently not used
> in this package but could be a source of further confusion.

Also from the "old package".

> 
> For the maintainerscripts I'll have to reread the relevant policy parts myself
> first. If it was my package I wouldn't even install a menu item for such a
> tool but that's up to you in the end. Oh and dh_installmenu exists to free
> one from the burden of writing the correct maintainer scripts for that task.

I have to chack that.

Thanks,
Werner