[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: asio [O] (#583862)



-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

Anton,

that's very useful feedback, thanks a lot. I figured I run lintian
from wheezy, that's why I didn't notice most of this.

On 02/23/2013 08:02 AM, Anton Gladky wrote:
> as I understood from #583862, you have found a sponsor for the
> package, right?

Looks like it, yeah.

> 1) Use DEP-3 for patches (at least Description, Author,
> Last-Update). 2) Remove the fix-makefile.patch, which is not listed
> in debian/patch/series 3) Changelog-entry #2 is not necessary
> IMHO. 4) Compat 7 should be better changed to the newer 9 as well
> as BD in control. It will allow also to inject hardened
> buildflags. 5) Standards-Version is already 3.9.4 6) As I
> understood from #583862, there is already a VCS on collab-maint, 
> add corresponding fields into control-file. 7) Use in debian/rules
> dh_auto_configure -- --prefix=........ instead of "configure". It
> should be more "nicely" 8) dh 9 sets the "correct" buildflags in
> many cases. Do you really need to set them explicitly? 9) Add
> --parallel option to dh for faster building. 10) The upload should
> be targeted to experimental branch due to a freeze-period.

I'll take care of these Monday - at the latest.

Regards

Markus Wanner
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREDAAYFAlEoeRYACgkQsPwMloDjyo/SogCdHxWHeVH/k90w/KUkXMk70VqH
/FEAniZYUnwpdP4D3Kc8MH3tpmrzfHxx
=qFG1
-----END PGP SIGNATURE-----


Reply to: