> Hi Andreas, > > On Thu, Dec 19, 2013 at 12:00:25PM +0100, Andreas Rönnquist wrote: > > I am looking for a sponsor for my package "xye" > > I like Xye, so I thought I'd give your package a look, with the intent > of sponsoring it eventually. Thank you, much appreciated! > I've just got a couple of comments: > * debian/repack is nice but seems like an awful lot of effort to > remove two files; have you noticed the new Files-Excluded header in > debian/copyright which uscan now supports? Ah, I hadn't - thanks! Well, I am kind of irritated on that bug I mentioned in README.source (##635920) which makes it impossible to use git-import-orig --uscan in combination with a debian/repack script... I guess using the mentioned Files-Excluded would solve this? > * The manpage doesn't follow the typical Unix manpage style, although > if there are no command-line options then the text you've written is > good enough. You might get bug reports requesting the manpage to > document how to play but until then... I'll think I'll wait for those bug reports... ;) > * You should update debian/copyright to include yourself. Done. > > Incidentally while trying to determine whether xye takes any > command-line parameters, I discovered that specifying any parameter > causes xye to crash! (I'll file a bug...) > Oh! I have managed to include a patch that fixes this problem, but when doing so I found more related problems - if running with a folder which doesn't contain any data files it still segfaults (but later). I will try to put together a patch for this problem too. (I have pushed my current changes to alioth). Would you like me to put together a new package on mentors, or do you simply get the gbp packaging from alioth? best regards, and many thanks -- Andreas Rönnquist gusnan@gusnan.se
Attachment:
signature.asc
Description: PGP signature