Bug#730009: Review
Hi Cameron,
I have some improvements and suggestions for your package
elementary-icon-theme/3.2-2.
I’m not a DD.
Where did you acquire the orig tarball? I can’t find version
3.2 on the download page.[1]
I think section x11 would be better than misc; many *-icon-theme
packages are in x11.
There’s a newer Debian Policy out: 3.9.5.[2]
There’s also a newer debhelper compat level, 9.
In d/rules, you probably want to override dh_install instead of
dh_auto_install. dh_auto_install tries to use the upstream build
installation target and as there is none, just does nothing.
dh_install is the program that copies the files and dirs specified
in debian/install. The man pages will explain more.
AUTHORS and CONTRIBUTORS files could be installed to the doc
directory.
The version of dpkg in unstable uses xz compression by default, but
I see the uses of keeping that override_dh_builddeb as it’ll
create xz-compressed deb with the older versions of dpkg as well.
The package has lintian warnings:
* P: elementary-icon-theme source: unversioned-copyright-format-uri http://dep.debian.net/deps/dep5/
That’s easily fixed, just use the versioned copyright format URI.
* I: elementary-icon-theme source: debian-watch-file-is-missing
I investigated the elementary icons download page and created one
you can use.
debian/watch:
| version=3
| http://launchpad.net/elementaryicons/+download \
| .*/(.+)/\+download/elementary(?:icons.*|-icon-theme-.*|_.*)?\
| \.(?:zip|tgz|tbz|txz|(?:tar\.(?:gz|bz2|xz)))
* P: elementary-icon-theme: no-upstream-changelog
AFAIK, this isn’t such a big deal.
* I: elementary-icon-theme:description-synopsis-might-not-be-phrased-properly
and
I: elementary-icon-theme: extended-description-is-probably-too-short
Please try to fix those, having good short and long descriptions for the
package is important.
[1] https://launchpad.net/elementaryicons/+download
[2] http://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt
Best Regards,
-- Juhani Numminen
Reply to: