Bug#721424: RFS: pentobi/7.1-1

To: Juhani Numminen <juhaninumminen0@gmail.com>, 721424@bugs.debian.org
Subject: Bug#721424: RFS: pentobi/7.1-1
From: Paul Wise <pabs@debian.org>
Date: Sat, 23 Nov 2013 09:20:39 +0800
Message-id: <[🔎] CAKTje6Hd5yUC6n2i0nw5xKe=7AaHk5Aa2kYqtnCRtanW6y5fCQ@mail.gmail.com>
Reply-to: Paul Wise <pabs@debian.org>, 721424@bugs.debian.org
In-reply-to: <20130831113631.4964.76075.reportbug@localhost.localdomain>
References: <20130831113631.4964.76075.reportbug@localhost.localdomain>

On Sat, Aug 31, 2013 at 7:36 PM, Juhani Numminen wrote:

> I am looking for a sponsor for my package "pentobi".

Uploaded, thanks for taking care of the package.

Here are some things you might want to look at:

Please send upstream these links.

http://tieguy.org/blog/2012/03/17/on-the-importance-of-per-file-license-information/
http://wiki.debian.org/UpstreamGuide

You might want to run tagpending after closing bugs in
debian/changelog in future.

There is a newer Debian policy out recently.

http://www.debian.org/doc/debian-policy/upgrading-checklist

Don't list lintian tags in the patch's Subject, that is for the description

What do you think about enabling the KDE thumbnailer?

Might want to add a debian/upstream file.

https://wiki.debian.org/UpstreamMetadata

Some of the PNG and ICO images were or look like they were created in
SVG format, they should be rendered from the SVGs at build time
instead. Preferrably upstream would remove them from the tarball and
VCS but if they are unwilling to do that they should be removed before
dh_auto_configure is run.

Likewise I wonder if there is any way to generate the screenshots at
build time so they look correct for the version of pentobi that is
being built.

Recent versions of nsis 3 support Unicode so this file can be
converted to UTF-8:

./windows_installer/German.nsh

Please upload a screenshot for the new version.

http://screenshots.debian.net/upload

Automated checks:

https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package

lintian

P: pentobi: no-upstream-changelog

cme

Warning in 'control source Standards-Version' value '3.9.4': Current
standards version is 3.9.5
Warning in 'control binary:pentobi Synopsis' value 'clone of Blokus, a
strategy board game based on the concept of polyominoes': Synopsis is
too long.
Warning in 'patches:"0001-hyphen-used-as-minus-sign.patch" Synopsis'
value <undef>: Empty synopsis (code is: 'defined $_ && /\w/ ? 1 : 0
;')
Warning in 'patches:"0002-desktop-entry-keywords.patch" Synopsis'
value <undef>: Empty synopsis (code is: 'defined $_ && /\w/ ? 1 : 0
;')

blhc

CXXFLAGS missing (-fPIE)
LDFLAGS missing (-fPIE -pie -Wl,-z,now)

cppcheck

[src/libboardgame_sgf/Node.h:222]: (error) Reference to auto variable returned.

desktop-file-validate

./src/pentobi_kde_thumbnailer/pentobi-thumbnail.desktop: error: key
"MimeType" is present in group "Desktop Entry", but the type is
"Service" while this key is only valid for type "Application"

pep8

./tools/twogtp/analyze.py:7:1: E302 expected 2 blank lines, found 1
./tools/twogtp/analyze.py:46:1: E302 expected 2 blank lines, found 1
./tools/twogtp/analyze.py:53:1: E302 expected 2 blank lines, found 1
./tools/twogtp/analyze.py:62:9: E126 continuation line over-indented
for hanging indent
./tools/twogtp/analyze.py:63:9: E126 continuation line over-indented
for hanging indent
./tools/twogtp/analyze.py:146:1: W391 blank line at end of file
./tools/twogtp/split-gamefile.py:7:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:14:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:17:47: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:17:49: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:17:62: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:17:64: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:18:39: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:18:41: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:19:1: W293 blank line contains whitespace
./tools/twogtp/twogtp.py:47:32: E711 comparison to None should be 'if
cond is not None:'
./tools/twogtp/twogtp.py:51:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:98:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:106:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:130:1: W293 blank line contains whitespace
./tools/twogtp/twogtp.py:131:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:145:19: E201 whitespace after '['
./tools/twogtp/twogtp.py:145:28: E202 whitespace before ']'
./tools/twogtp/twogtp.py:147:19: E201 whitespace after '['
./tools/twogtp/twogtp.py:147:38: E202 whitespace before ']'
./tools/twogtp/twogtp.py:157:16: W291 trailing whitespace
./tools/twogtp/twogtp.py:171:26: W291 trailing whitespace
./tools/twogtp/twogtp.py:221:80: E501 line too long (80 > 79 characters)
./tools/twogtp/twogtp.py:224:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:246:9: E126 continuation line over-indented
for hanging indent
./tools/twogtp/twogtp.py:254:9: E126 continuation line over-indented
for hanging indent

todo

./src/libpentobi_mcts/State.cpp:    // TODO: m_nu_passes should be
initialized without assuming alternating
./src/pentobi/Main.cpp:/** @todo: Move to an extra file to encapsulate
the inclusion of <windows.h>,
./src/libpentobi_base/BoardConst.cpp:    // TODO: Better distinction
between board type and set of pieces.

duplicate files

./src/pentobi/manual/en_CA/shortcuts.html
./src/pentobi/manual/en_GB/shortcuts.html

./src/pentobi/manual/en_CA/trigon_rules.html
./src/pentobi/manual/en_GB/trigon_rules.html

./src/pentobi/manual/en_CA/user_interface.html
./src/pentobi/manual/en_GB/user_interface.html

./src/pentobi/manual/en_CA/index.html
./src/pentobi/manual/en_GB/index.html

./src/pentobi/manual/en_CA/system.html
./src/pentobi/manual/en_GB/system.html

./src/pentobi/manual/en_CA/classic_rules.html
./src/pentobi/manual/en_GB/classic_rules.html

./src/pentobi/manual/en_CA/license.html
./src/pentobi/manual/en_GB/license.html

./src/pentobi/manual/en_CA/duo_rules.html
./src/pentobi/manual/en_GB/duo_rules.html

./src/pentobi/manual/en_CA/junior_rules.html
./src/pentobi/manual/en_GB/junior_rules.html

./src/pentobi/icons/pentobi-forward.png
./src/libpentobi_gui/icons/go-next.png

./src/pentobi/icons/pentobi-forward.svg
./src/libpentobi_gui/icons/go-next.svg

/usr/share/games/pentobi/translations/libpentobi_gui_en_GB.qm
/usr/share/games/pentobi/translations/libpentobi_gui_en_CA.qm

-- 
bye,
pabs

http://wiki.debian.org/PaulWise

Reply to:

Follow-Ups:
- Upstream metadata (was: Bug#721424: RFS: pentobi/7.1-1)
  - From: Mathias Behrle <mathiasb@m9s.biz>
- Bug#721424: RFS: pentobi/7.1-1
  - From: Juhani Numminen <juhaninumminen0@gmail.com>

Prev by Date: Re: Packaging with Python Disutils
Next by Date: Bug#668505: marked as done (RFS: gemrb/0.8.0-1 [ITP] -- Open-source engine for Black Isle Studio's RPGs)
Previous by thread: Bug#730220: RFS: libwebsitesnapshot-qt/1.03 [ITP] -- QT library for website screenshots
Next by thread: Upstream metadata (was: Bug#721424: RFS: pentobi/7.1-1)
Index(es):
- Date
- Thread