[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#729375: RFS: authprogs/0.5.1-1 [ITP #616126]



Just a note on your style of reply. Not including blank lines around
your responses while also interleaving them with my mail makes your mail
really hard to read. You can also strip the parts of my mail that are
unnecessary for your mail.

On Fri, 2013-11-15 at 17:40 +0100, Alex Mestiashvili wrote:

> Fixed

The debian/copyright in the package I just downloaded from mentors still
has GPL-2.0+, are you sure this was fixed?

> there is a bug in setup.py, fixed with the patch

Hmm, I don't see any patch in the package on mentors.

> using --buildsystem=pybuild in debian/rules fixes most of the issues
> above

Probably a good idea to add it there then?

> fixed, do you mean the not escaped dots in the example:?  if yes, than 
> wiki is updated too.

No, I mean that the URLs in the example are completely wrong due to
changes at github. If you could fix them that would be good.

https://wiki.debian.org/debian/watch#GitHub

> Nice tool, thanks, but it doens't really matter if there is a visually 
> wrong indentation or ?

PEP-8 is just a style guide for python and pep8 is a tool for checking
code against the style guide. Both PEP-8 and pep8 are therefore
completely optional but possibly a good idea to follow.

http://www.python.org/dev/peps/pep-0008/

> I'll try to address the rest of issues soon, but for now I've uploaded a 
> "fixed" version of authprogs to mentors.

Please ping the RFS bug when at least the first 3 things are fixed in
the Debian package on mentors, preferably also fixed upstream.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: