Hi Mariusz,
here a short review of your niceshaper package on mentors.d.n (might not be complete):
- COPYING and debian/copyright do not match: Is your software GPL-2 or "GPL-2+", which means "GPL v2 or later"?
- remove trailing whitespaces in debian/ files (use egrep '\s$' debian/*).
- remove the comments at the beginning of debian/rules about its dh-make origin.
- fix lintian warnings:
W: niceshaper source: out-of-date-standards-version 3.9.3 (current is 3.9.4)
W: niceshaper: hardening-no-relro usr/bin/niceshaper
I: niceshaper: hardening-no-fortify-functions usr/bin/niceshaper
-> Enable hardening: switch to debian/compat 9 and adapt the makefiles accordingly: they should append to
the build flags. The code does not compile with -Werror=format-security so you need either overwrite this flag or
fix your code.
- As it seems that the configuration of niceshaper needs to be adapted nearly everywhere,
it does not make much sense to start it automatically with some example settings.
Therefore I recommend you to disable it by default (add a commented /etc/default/niceshaper
file with something like NICESHAPER_ENABLE=false and check it in the init.d script).
Add a README.Debian which describe what the user needs to do to enable it.
But maybe you have a better idea, how to improve the usage for normal user.
- bonus (optional): support vim-addon-manager (add /usr/share/vim/registry/niceshaper.yaml, see
/usr/share/doc/vim-addon-manager/addons-proposal.txt for details).
Best regards,
Johann Felix Soden
Attachment:
signature.asc
Description: This is a digitally signed message part