Bug#721208: 0.1-6 uploaded

[Eriberto <eriberto@eriberto.pro.br>]

Hi Sean,

Several suggestions for you:

debian/control:
    - change debhelper (>=9.0.0) to debhelper (>=9).
    - why you are using priority extra? Your package conflicts with
other?[1] I suggest to use optional.
    - your VCS control is disabled... Please, enable it and use a VCS
(can be debian.org, github etc).

debian/copyright:
    - the code has extra copyrights. Example:
mugshot/CameraMugshotDialog.py has a copyright from you and Rick
Spencer. You should put all authors in debian/copyright. Please, see
an example here[2].
    - you used the GPL-3.0+ license. However, the code headers hasn't
"or later" expression. Thus, you must use GPL-3.0 instead of the
GPL-3.0+.

debian/menu: why not use a icon.xpm for your application???

debian/mugshot.1: you are the upstream! The best is create a manpage
in your code and release a new version. (I already made it several
times to fix the code and make Debian happy!)

debian/README.source: dpatch is dead. The current patch system is
quilt and you haven't patches. This file is useless. Please, remove
it.

debian/rules: I suggest to append --paralell to "dh $@" lines.

The package has a lintian message:

I: mugshot: package-contains-empty-directory usr/share/mugshot/media/

Please, see refining lintian[3] for details.

I got some warnings and errors when building the package. See:

-------------------------------------------------------------
WARNING: the following files are not recognized by DistUtilsExtra.auto:
  ChangeLog
  help/C/figures/browse.png
  help/C/figures/camera.png
  help/C/figures/file_chooser.png
  help/C/figures/icon.png
  help/C/figures/libreoffice.png
  help/C/figures/main.png
  help/C/figures/password_dialog.png
  help/C/figures/pidgin.png
  help/C/figures/select_from_stock.png
  help/C/figures/stock_browser.png
  help/C/figures/take_a_photo.png
  help/C/index.page
  help/C/mugshot-quickstart.page
  help/C/mugshot-take-a-picture.page
  mugshot.desktop.in
  po/mugshot.pot
-------------------------------------------------------------
pyversions: missing X(S)-Python-Version in control file, fall back to
debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions
ERROR: Python module helpers not found
ERROR: Python module helpers not found
ERROR: Python module helpers not found
ERROR: Python module Window not found
ERROR: Python module mugshotconfig not found
ERROR: Python module mugshotconfig not found
ERROR: Python module Builder not found
ERROR: Python module pexpect not found
ERROR: Python module dbus not found
ERROR: Python module cairo not found
-------------------------------------------------------------
WARNING: the following files are not recognized by DistUtilsExtra.auto:
  ChangeLog
-------------------------------------------------------------

What is this???

    ├── lib
    │   └── python2.7
    │       └── dist-packages
    │           ├── mugshot
    │           │   ├── CameraMugshotDialog.py ->
../../../../share/pyshared/mugshot/CameraMugshotDialog.py
    │           │   ├── __init__.py ->
../../../../share/pyshared/mugshot/__init__.py
    │           │   └── MugshotWindow.py ->
../../../../share/pyshared/mugshot/MugshotWindow.py
    │           ├── mugshot-0.1.egg-info ->
../../../share/pyshared/mugshot-0.1.egg-info
    │           └── mugshot_lib
    │               ├── Builder.py ->
../../../../share/pyshared/mugshot_lib/Builder.py
    │               ├── CameraDialog.py ->
../../../../share/pyshared/mugshot_lib/CameraDialog.py
    │               ├── helpers.py ->
../../../../share/pyshared/mugshot_lib/helpers.py
    │               ├── __init__.py ->
../../../../share/pyshared/mugshot_lib/__init__.py
    │               ├── mugshotconfig.py ->
../../../../share/pyshared/mugshot_lib/mugshotconfig.py
    │               └── Window.py ->
../../../../share/pyshared/mugshot_lib/Window.py


The installation is using several relative symliks and it will take
you to a role... Use absolute links.

Please, refer the package name and location in mentors in next time.

Hope this help.

Regards,

Eriberto

PS: I can't sponsor you.

[1] http://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities
[2] http://anonscm.debian.org/gitweb/?p=collab-maint/core-network.git;a=blob_plain;f=debian/copyright
[3] http://eriberto.pro.br/blog/?p=1289


2013/8/29 Sean Davis <smd.seandavis@gmail.com>:
> I have uploaded 0.1-6 which makes the package lintian-clean.
> Please review my package for upload.