Re: Bug#719985: RFS: mrrescue/1.02-1 [ITP]
Andreas Moog writes:
> All assets (graphics, music, text) are licensed under a Creative Commons
> BY-NC-SA 3.0 Unported License. See
> http://creativecommons.org/licenses/by-nc-sa/3.0/deed.en_US for more info.
>
> As far as I understand it, that means your package can not enter Debian,
> but has to go into non-free. So, the "Section" in debian/control should
> be non-free/games.
Ah monkeys. You're right. Changed.
>
>> Build-Depends: debhelper (>= 9.0.0)
>
> debhelper doesn't use that versioning scheme anymore, a simple ">= 9"
> should be what you need.
>
> In debian/rules you could remove all the comments about it being a
> sample file. I suggest adding a brief comment in debian/rules about your
> reasoning of adding the dh_installinit override, like "Work around
> debhelper bug #719359".
>
> Why is this package architecture-any? It should run on all architectures
> where "love" is available.
>
> Lintian says:
>
> I: mrrescue source: debian-watch-file-is-missing
> P: mrrescue: no-upstream-changelog
> I: mrrescue: description-synopsis-might-not-be-phrased-properly
> I: mrrescue: arch-dep-package-has-big-usr-share 11624kB 100%
> I: mrrescue: desktop-entry-lacks-keywords-entry
> usr/share/applications/mrrescue.desktop
Thanks for the review. Everything has been fixed apart from the
upstream changelog. Upstream don't supply any. Only commit logs.
--
Steven Hamilton
I don't look like two zombies
Reply to: