[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#718893: RFS: coinutils/2.9.4-1 [ITA] -- CoinOR base library



Hello,

Thanks for taking care of this package. Last year I tried to sort all
these packages. In the process I adopted -cbc and ITA'd -cgl but I
haven't had enough time to update them. At that time I documented the
relations between the packages, and what's necessary to do on the
following page:

https://wiki.debian.org/CoinOr

As you noted, the SONAME of libcoinutils changed from 0 to 3. This
requires a transition, which needs to be coordinated with the release
team (https://wiki.debian.org/Teams/ReleaseTeam/Transitions). This
also means that the reverse-dependencies (-symphony, -flopc++, -osi,
clp, -cgl and -cbc) need to be adapted so that they can use the new
version. This can be done in experimental.

As for the package itself (note that because of the SONAME bump it
can't be uploaded to unstable as is), I have a few remarks:

> --- coinutils-2.6.4/debian/coinor-libcoinutils-dev.install	2008-09-14 20:37:56.000000000 +0200
> +++ coinutils-2.9.4/debian/coinor-libcoinutils-dev.install	2013-08-06 05:10:15.000000000 +0200
> @@ -1,4 +1,6 @@
>  debian/tmp/usr/include/coin
> -debian/tmp/usr/lib/lib*.a
> -debian/tmp/usr/lib/lib*.la
> -debian/tmp/usr/lib/lib*.so
> +debian/tmp/usr/share/coin
> +debian/tmp/usr/lib/*/lib*.a
> +debian/tmp/usr/lib/*/lib*.la
> +debian/tmp/usr/lib/*/lib*.so
> +debian/tmp/usr/lib/*/pkgconfig/*.pc

You seem to be adding multiarch support. This should be mentioned in
the changelog. Shipping *.la files is now deprecated, but it has to be
fixed from the leaves of the graph so you can't do anything about it
in this upload.

https://wiki.debian.org/ReleaseGoals/LAFileRemoval

> -Standards-Version: 3.9.0
> +Standards-Version: 3.9.4

This should be mentioned in the changelog along with the changes you
made specifically for this (or "no changes needed" if appropriate).

> +export DH_VERBOSE=1

It shouldn't be set it directly in the rules file.

I didn't try to build the package nor run lintian, since IMHO the most
important thing is to solve the transition problem.

Thanks again for putting energy in Coin-OR!

-- 
Etienne Millon


Reply to: