owner 715172 ! tag 715172 + pending tag 715172 + moreinfo thanks Hi Daniel, On Sat, 6 Jul 2013 18:21:08 +0200, Daniel Augustin Pavel <daniel.pavel@gmail.com> wrote: > I am looking for a sponsor for my package "solaar" > > * Package name : solaar > Version : 0.8.99.10-3 > Upstream Author : Daniel Pavel <daniel.pavel@gmail.com> > * URL : http://pwr.github.io/Solaar > * License : GPLv2 > Section : misc > > It builds those binary packages: > solaar - Logitech Unifying Receiver peripherals manager for Linux > solaar-gnome3 - gnome-shell/Unity integration for Solaar I was quite pleased to see this RFS! I'd love to help you get the package ready and sponsor it for you. Here is my review of the package so far: * great job on the ConsoleKit / systemd support, with minimal debconf prompting, nice! * personally I'd drop substvars.extra (and define the substvars in debian/rules, with a solaar: prefix) and rules.extra, but that's really a question of preference rather than best practice as far as I'm concerned * why not use dh compat level 9? * since this is a new package, you should file a separate ITP (alongside this RFS), indicate that the RFS blocks the ITP, and close the ITP in debian/changelog (not the RFS, I'll do that when I sponsor the package) * in debian/copyright, you need to give the license paragraphs for the SVG and PNG files, in the same way as your GPL-2 license paragraph; "These files were copied from the Oxygen icon theme" should go in a Comment: stanza * still in debian/copyright, you don't need "Copyright (C)" in your Copyright: stanzas (so just "Copyright: 2012-2013 Daniel Pavel") Outwith the Debian-specific packaging, you should add appropriate headers to your source files in bin and lib, as described in the "How to Apply These Terms to Your New Programs" at the end of /usr/share/common-licenses/GPL-2. Regards, Stephen
Attachment:
signature.asc
Description: PGP signature