[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#706514: RFS: dcraw/9.17-1



Hi Anton,
I finally got around to looking at the package again.

Currently getsource doesn't run due to some minor upstream format change.

Can you fix that?

I fixed the first bug it runs into.  It still doesn't seem to work, though.
No idea what is missing.


Yes, but in the previous uploaded version there are in "patch-section"
only Makefile, badpixels and manpages. You have now also configure,
Makefile.in etc.

That's a thing that I still don't understand.  In an AutoTools environment
all you need is configure.in and Makefile.in.  The files configure and
Makefile are then created automatically.  However when I remove configure
and Makefile from the patch, nothing is built at all.

Please, add into the patch only Makefile and badpixels. Manpages can be stored
somewhere in debian-directory (debian/manpages, for example).


All non-upstream manpages are in debian/manpages now.


I have now uploaded dcraw-9.17-1.1, which contains all my fixes and
cleanups in a single changelog entry.

Ok, looks good. Please, clean patches,

see above: The manpages have been removed, but configure and Makefile are still
there.

 try to fix watch-file,

Beyond my time/skill resources.  Besides, the getsource script is not a real
watch file.

use DEP-5 for
copyright,

The standard says this is optional.
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

 check README.debian (update or remove it, if the info is outdated),

Done.

use dcraw.manpages and dcraw.exapmles instead of putting them into the
override_*.

I don't understand what you mean here.

Best,
Oliver


Thanks for your work,

Anton


Reply to: