Bug#696782: RFS: sequitur-g2p/0.0.r1668-1 [ITP] -- Grapheme to Phoneme conversion tool

[Giulio Paci <giuliopaci@gmail.com>]

Il 13/04/2013 00:31, Jakub Wilk ha scritto:
> * Giulio Paci <giuliopaci@gmail.com>, 2013-04-07, 23:00:
> Anyway, I'd rather make the build-dependency unversioned, to make squeeze backporters' life easier.

Now it is unversioned.

> And now for something completely different... Typos:

Updated 1005_spelling_fixes.patch accordingly.

> Estimation.cc has this twice:
> #if 1 // DEBUG
> Shouldn't that be "#if 0 ..."?

Probably yes. Added 1006_remove_DEBUG_prints.patch in order to change this.

> Using "except" without specifying exception type is bad idea:
> http://docs.python.org/2/howto/doanddont.html#except

Added 1008_avoid_except_usage_without_type.patch. The situation is not very much different anyway, as the patch just replaces "except" with "except Exception".

> gOpenIn and gOpenOut functions pass filenames to shell unescaped. They probably should just use the gzip module.
> FileWriter, FileReader and StoredCounts classes have the same problem. (Although these three are not used in Debian binary packages AFAICS.)

Changed all of them to use the gzip module.

Bests,
	Giulio.