[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#705237: RFS: python-heatclient/0.2.2-1 [ITP] -- client library and CLI for OpenStack Heat



Hi Jakub,

Thanks a lot for your reviews.

On Fri, Apr 12, 2013 at 1:29 AM, Jakub Wilk <jwilk@debian.org> wrote:
> (I don't intend to sponsor this package.)
> I recommend against using ${python:Provides}. See
> <http://lists.debian.org/20110324164804.GA5919@jwilk.net> for rationale.
>
> /usr/bin/heat uses the pkg_resources module, so the package should depend on
> (or recommend) python-pkg-resources.
>
> <ADVERT>
> You may want to give lintian4python a try. It spotted both of the above
> problems!
> </ADVERT>

Fixed, I hope lintian4python will soon move to sid. :-)

> Any reason for not running tests at build time? Tests love begin run!
>

Enable run tests at build time.

+override_dh_auto_test:
+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
+       set -e ; for pyversion in $(shell pyversions -vr); do
nosetests-$$pyversion -v; done
+endif

> The manual page is currently completely useless... I see no point in
> installing it to the binary package.

Removed.

The last upload:

dget -x http://mentors.debian.net/debian/pool/main/p/python-heatclient/python-heatclient_0.2.2-1.dsc

http://anonscm.debian.org/gitweb/?p=openstack/python-heatclient.git;a=summary


Regrads,
 Prach


Reply to: