[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#696782: RFS: sequitur-g2p/0.0.r1668-1 [ITP] -- Grapheme to Phoneme conversion tool



* Jakub Wilk <jwilk@debian.org>, 2013-02-16, 13:10:
Are the Python modules shipped by this package supposed to be used by other software?
If not, they should be moved to a private directory.
If yes, then they need to be renamed or moved into a namespace, because their are way to generic ("tool", "misc", etc.).

It is the former case. It was my fault because I did not read carefully the Debian policy about Python. I moved the modules to /usr/lib/sequitur-g2p/python/<version>/dist-packages. After installation I also change the main script so that it can locate the modules.
Is this approach ok?

I'm afraid that dh_python2 doesn't support such layout.
I asked for advice on how to handle similar cases on debian-python@:
http://lists.debian.org/20130216120158.GA3162@jwilk.net

Okay. So I see the following ways to go forward:

B) Install the modules as public ones, but put them in a namespace starting with underscore, say _sequitur_gp2.

C1) Build the modules only for the default Python version and install them to a private directory (/usr/lib/sequitur-gp2/). But then this will trigger #702677, so either implement a work-around for it, or wait until it's fixed, or switch back to python-support...

I leave to your discretion which option to choose. B is my preference, although it didn't gain recognition on debian-python.


Now some other business:

There are some tests, it would be good to run them at build time. (Although at least some of them seem to only touch code that doesn't even end up in binary packages...)

If I were packaging this myself, I'd use "0+r1668-1" as version number, just in case upstream decides to make a proper release versioned "0.0.1". But you can keep the current versioning scheme if you like it, of course.

Did you manually edit the manpage? If yes, then "DO NOT MODIFY THIS FILE" should be probably removed; otherwise it might be a good idea to regenerate it at build time.

--
Jakub Wilk


Reply to: