Bug#702588: RFS: rrep/1.3.5-1
Here is a review:
In future, you might want to X-Debbugs-CC your earlier sponsors on the
RFS bug submission.
Since you appear to be upstream for this, please read our upstream
guide and some of the links in it:
http://wiki.debian.org/UpstreamGuide
I would encourage you to improve the watch file:
http://wiki.debian.org/debian/watch#Common_mistakes
I personally prefer --with autoreconf (using dh-autoreconf) to --with
autotools_dev. This ensures that when Debian QA folks do their usual
regular archive rebuilds, the build system gets checked for
rebuildability too.
Please add --parallel to your invocation of dh.
I would suggest that the upstream build system should install
doc/rrep.info, rather than dh_installinfo.
It doesn't appear to be nessecary to distribute the upstream README in
the binary package. The package description covers the second part and
the rest isn't particular.y useful.
The copyright/license info appears to be insufficient. The README is
not GPL-3+ and various files are copyright by the FSF. Various *.m4
files are also not GPL.
Why do you have ${shlibs:Depends} in Pre-Depends instead of Depends?
That looks like a mistake to me.
You don't appear to have any translations but you do have i18n, I
would suggest registering rrep with transifex to get in contact with
translators:
https://www.transifex.net/
Please ensure that doc/rrep.info is regenerated at build time.
Please update the debtags information for this package:
http://debtags.debian.net/rep/todo/maint/asnelt@asnelt.org#rrep
rrep contains something with a command-line interface, it would be
nice to create a screenshot or two showing typical usage.
http://screenshots.debian.net/package/rrep
Automated checks:
http://packages.qa.debian.org/r/rrep.html
http://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
configure:
configure: WARNING: libacl development library was not found or not usable.
configure: WARNING: rrep will be built without ACL support.
gcc:
copy-file.c: In function 'qcopy_file_preserving':
copy-file.c:143:9: warning: ignoring return value of 'chown', declared
with attribute warn_unused_result [-Wunused-result]
blhc:
Lots of this: CFLAGS missing (-fPIE) ....
One of this: LDFLAGS missing (-fPIE -pie -Wl,-z,now) ....
cppcheck:
[lib/rpmatch.c:113]: (error) Memory leak: safe_pattern
[src/rrep.c:573] -> [src/rrep.c:575]: (error) Possible null pointer
dereference: next_path - otherwise it is redundant to check it against
null.
[lib/regcomp.c:2848]: (error) Uninitialized variable: symb_table
[lib/regcomp.c:2847]: (error) Uninitialized variable: table_size
[lib/regcomp.c:2850]: (error) Uninitialized variable: table_size
msgfmt:
msgfmt: ./po/rrep.pot: warning: source file contains fuzzy translation
lacheck:
lots of warnings on build-aux/texinfo.tex
clang compiler:
Build failure: http://clang.debian.net/logs/2013-01-28/rrep_1.3.3-2_unstable_clang.log
ports:
Build failure on x32 port:
http://buildd.debian-ports.org/status/package.php?p=rrep
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: