[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#702072: RFS: tilda/1.1.4-1 [ITA]



Hi Anton,

thanks for reviewing my package. I have added a new branch tilda-debian-1-1 to my github repository and put the debian/ folder in there, more comments below:

On 02/03/13 16:19, Anton Gladky wrote:
Hi Sebastian,

thanks for working on this package. I think it is ok to switch to a fork
as the original software is not developed any more.

Some notes/questions on your package:

1) Remove changelog.new.
2) Use VCS for maintaining the package and uncomment corresponding lines
in control-file.
3) Current Standards-version is 3.9.4
4) Convert copyright-file to a DEP-5 format, who is copyright-holder
after 2008?
DONE
5) What is debian/rules.small? If it works, why do you keep an old
version? If you plan to use the current debian/rules, it should be
cleaned also, using override_dh-commands.
I forgot to remove that, debian/rules is the correct one.
6) Lintian's complaining on hardening should be investigated, not just
simply overridden.
I did investigate, and decided its save to ignore the warnings. Is there anything that would indicate its not?
7) tilda.dirs, seems, useless.
Its not, the package doesnt build without the tilda.dirs file.
8) Clean watch-file. It should be 3-lines long.
DONE
9) Your package fails to build:

================
cp -f /usr/share/misc/config.sub config.sub
cp -f /usr/share/misc/config.guess config.guess
dh_autoreconf
Can't exec "autopoint": No such file or directory at
/usr/share/autoconf/Autom4te/FileUtils.pm line 345.
autoreconf: failed to run autopoint: No such file or directory
autoreconf: autopoint is needed because this package uses Gettext
dh_autoreconf: autoreconf -f -i returned exit code 1
make: *** [config.status] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
=================
Added autopoint as build dependency, now it should work. But when I run pbuilder --build to build it inside a debian chroot, then I still get some configure errors. I have to assume that some build dependencies are missing, but I really dont know how to fix that since I dont get any warnings. I have no real idea what pbuilder is doing inside the chroot and how i can reproduce that. If you could help fixing this that would be great.
10) Do you really need debian/source/options?
No, removed it.
Cheers,

Anton
Thanks Lanoxx

On 03/02/2013 02:23 PM, Lanoxx wrote:
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "tilda"

  * Package name    : tilda
    Version         : 1.1.4-1
    Upstream Author : Sebastian Geiger <lanoxx@gmx.net>
  * URL             : https://github.com/lanoxx/tilda
  * License         : GPL-2
    Section         : x11

It builds those binary packages:

   tilda - Gtk based drop down terminal for Linux and Unix

To access further information about this package, please visit the
following URL:

   http://mentors.debian.net/package/tilda


Alternatively, one can download the package with dget using this command:

   dget -x
http://mentors.debian.net/debian/pool/main/t/tilda/tilda_1.1.4-1.dsc

More information about tilda can be obtained from
https://github.com/lanoxx/tilda.

I have already spawned a discussion about switching to a new upstream
location and becoming new maintainer at this bug #695574 [1].

Please also see bug #583248 [2], which states that the current
maintainer is MIA since 2010-05-26.

Note that I'm targeting unstable not experimental, because I believe
that given the amount of bugs my package fixes makes this package more
stable than the one which is currently in unstable.

  Changes since the last upload:

  tilda (1.1.4-1) unstable; urgency=low

   * New upstream release (Closes: #695574, #692904)
   * Added a watch file (Closes: #501739)
   * Use x-www-browser as default (Closes: #552505)
   * Use word characters setting, thanks to Liu Yubao
     <yubao.liu@gmail.com> (Closes: #506855)
   * Remove deprecated dpatch and upgrade to packaging format "3.0 quilt"
     and update to Standards-Version to 3.9.3 and debhelper to 9,
     thanks to Jari Aalto <jari.aalto@cante.net> (Closes: #664358)
   * New maintainer (Sebastian Geiger), thanks to Davide Truffa for his
     previous work (Closes: #583248)
   * Update tilda.desktop file to be compatible with freedesktop.org,
     thanks to Jekyll Wu (Closes: #678129)

  -- Sebastian Geiger <lanoxx@gmx.net>  Sat, 23 Feb 2013 12:06:09 +0100

   Regards,
    Sebastian Geiger

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695574
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=583248





Reply to: