Hi Prach, as promised here is a review for libapache2-mod-geoip. * Please consider upgrading to new style (dh >= 7) rules style. It makes life easier to you and is more forward oriented. That said, your rules file looks ok but you could ease life to all of us, including you. * While you're at it, remove the boilerplate copyright messages in debian/rules. They are not needed. * debian/compat 7 is fine, but not up to date. Please verify if your package works fine with debhelper 9 and if so, raise the compatibility level. Don't forget to push the debhelper dependency because Lintian needlessly may warn you otherwise. * Please consider using the copyright format formerly known as dep5 for debian/copyright: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ * Since you build a single binary package only, there is no need to call the debhelper files libapache2-mod-geoip.apache2.suffix in debian/. You can just omit the package name if you want. This is entirely up to you though. * Your watch file does not work: $ uscan --report-status uscan warning: In debian/watch, no matching hrefs for watch line http://www.maxmind.com/download/geoip/api/mod_geoip2/mod_geoip2_([\d+\.]+|\d+)\.tar\.gz * There is no policy version 3.9.3.4. You either mean 3.9.3 or 3.9.4, with the latter being the most current one. * Please consider using a VCS for your packaging By the way: If you want, we can do another upload to experimental for Apache 2.2 with you as a maintainer set. -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D
Attachment:
signature.asc
Description: OpenPGP digital signature