[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: debian/watch for gitorious



On Fri, Mar 8, 2013 at 9:45 AM, Alfonso Sabato Siciliano wrote:

> I am making my first package (game: beret), the source of software is
> on gitorious: https://gitorious.org/beret  .
> What must I write in debian/watch? I don't find docs about.

This particular project has no releases and no git tags, so you can't
create a useful watch file.

I would suggest talking to upstream and asking them to make source
code tarball releases and git tags for them.

At the same time, you could point them at these guides for upstream projects:

http://www.freedesktop.org/wiki/Games/Upstream
http://wiki.debian.org/UpstreamGuide

I took a look at the git repository and found these issues, please
forward them upstream:

There is a copy of this font in the git repo, it should be removed and
packaged separately:

http://iotic.com/averia/

None of the C files contain copyright or license information, which is
a good idea:

http://tieguy.org/blog/2012/03/17/on-the-importance-of-per-file-license-information/

There is a Windows Thumbs.db in the git repo, that is useless and
should be removed.

A lot of the files have execute permission but they are not
executables so shouldn't have that.

credits.png and title.png contain pre-rendered text, they should be
rendered at runtime instead so that the text can be translated into
other languages.

I would suggest splitting tilesheet.png/spritesheet.png up into
individual tiles and sprites and loading them at runtime or creating
tilesheet.png/spritesheet.png at build time.

Many/all of the images appear to be created in the GIMP, are there any
XCF files? If so they should be in git and the PNG files should be
removed and rendered at build time.

All the music is pre-mixed, pre-encoded so not in an ideal form for
modification, can you ask upstream how they were created?

How were the sound effects created?

What format are the rooms files in? How are they supposed to be
modified? I see there is level2png.git, I wonder if it would be better
for the game itself to just load PNG files instead of using the
intermediate format. In any case, the best form for modification (PNG)
should be in git not the intermediate form (current level files) and
the level files should be created at build time.

The game fails to build because it uses an incorrect path to the SDL
header, I've just now sent upstream a patch for this.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


Reply to: