[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: asio [O] (#583862)



Hi Markus,

I have uploaded the package with some minor changes (see an attachment).
If you are not agree with them (changelog entries mostly), feel free to
drop them with the future uploads.

Pay attention, (Closes: #583862: did not work in your changelog.
Please, consider the package maintenance under the team.


On 03/04/2013 12:31 PM, Markus Wanner wrote:
>> 3) Changelog-entry #2 is not necessary IMHO.
> 
> Hm..  I merged this into the "New maintainer" line. Is there another
> place to thank the former maintainer? I kind of like these little
> pieces of appreciation. But yeah, it doesn't need to be the changelog.

You can write him an email, if you want. Try to write changelog-entries
shorter: they should not tell the whole life-story.

>> 4) Compat 7 should be better changed to the newer 9 as well as BD
>> in control. It will allow also to inject hardened buildflags.
> 
> I updated to 9.
> 
> Just wondering: wheezy ships with dh 8. Why not keep a lower
> requirement to allow for easier backports? What benefit does a newer
> debhelper compat level give?

dh 9 brings build-flags hardening and multiarch (maybe something else,
not sure).

>> 5) Standards-Version is already 3.9.4
> 
> Corrected. (No changes required.)
              ^^^^^^^^^^^^^^^^^^^
This should be in changelog.

Thanks for contribution.

Anton
From 6aac113f900cf8163323976ad6e3608bcf5e6e35 Mon Sep 17 00:00:00 2001
From: Anton Gladky <gladky.anton@gmail.com>
Date: Mon, 4 Mar 2013 22:18:02 +0100
Subject: [PATCH] Minor changes before upload.

---
 debian/changelog           |    9 ++++-----
 debian/libasio-dev.install |    2 +-
 debian/libasio-doc.docs    |    1 +
 debian/libasio-doc.install |    1 -
 4 files changed, 6 insertions(+), 7 deletions(-)
 create mode 100644 debian/libasio-doc.docs
 delete mode 100644 debian/libasio-doc.install

diff --git a/debian/changelog b/debian/changelog
index 2a06522..c92003b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,15 +1,14 @@
 asio (1.4.8-1) experimental; urgency=low
 
   * New upstream release.
-  * New maintainer. (Closes: #583862: ITA: asio -- cross-platform C++
-    library for network programming). Thanks to Simon Richter for
-    maintenance todate.
+  * New maintainer. (Closes: #583862).
   * Switch to dpkg-source 3.0 (quilt) format, splitting patches.
   * Drop the patch for src/Makefile.am, it got applied upstream.
-  * Drop the patch for Makefile.am, it isn't necessary, anymore.
+  * Drop the patch for Makefile.am, it isn't necessary anymore.
   * Adjust the SSLv2 disabling patch.
   * Migrate to debhelper 9, revamp the rules. Drop all custom build flags,
-    update to standards version 3.9.4, allow parallel builds.
+    allow parallel builds.
+  * Update to standards version 3.9.4. No changes.
   * Watch only releases with even minor version numbers, odd ones seem to
     be non-stable releases.
   * Migrate copyright info to machine readable format.
diff --git a/debian/libasio-dev.install b/debian/libasio-dev.install
index 98b24cf..41a1414 100644
--- a/debian/libasio-dev.install
+++ b/debian/libasio-dev.install
@@ -1 +1 @@
-debian/tmp/usr/include/*	/usr/include
+usr/include/*
diff --git a/debian/libasio-doc.docs b/debian/libasio-doc.docs
new file mode 100644
index 0000000..30d29de
--- /dev/null
+++ b/debian/libasio-doc.docs
@@ -0,0 +1 @@
+doc/*
diff --git a/debian/libasio-doc.install b/debian/libasio-doc.install
deleted file mode 100644
index 127f174..0000000
--- a/debian/libasio-doc.install
+++ /dev/null
@@ -1 +0,0 @@
-doc/*		/usr/share/doc/libasio-doc
-- 
1.7.10.4

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: