Bug#702174: RFS: estonianidcard/3.7.0 [ITP] -- Estonian ID card support packages
I don't intend to sponsor these packages, but here is a review:
mentors.d.n cut off my downloads early so I wasn't able to review all
the packages.
General:
Please run wrap-and-sort -sa to wrap various files.
The package descriptions are too short.
The Homepage redirects to its https version.
Some packages don't close their ITPs.
The comments in debian/rules are not needed.
The copyright information is incorrect.
I would suggest debhelper rules.tiny and compat 9 instead of cdbs.
Please run these automatic checks against your packages:
https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
The watch files make a couple of common mistakes:
http://wiki.debian.org/debian/watch#Common_mistakes
estonianidcard:
The package should probably be a native package?
The upstream tarball looks weird, it only contains an empty file.
esteidpkcs11loader:
The patch Fix-library-directory makes the package only work on
amd64/i386, please change the Architecture line in debian/control or
fix the patch.
Why is JavaScript code loading ELF shared libraries??! Especially
loading them from an absolute path is very wrong.
esteidfirefoxplugin:
No need to make override_dh_strip .PHONY.
No need to tell dh what the dbg package is since you do that for dh_strip.
override_dh_auto_configure is not needed.
Please ask upstream to remove the pre-compiled or generated files from
their tarball:
keychain-tool firefox-win/plugin-win.aps firefox-win/plugin-win.res ie/dlldata.c
Please ask upstream to remove the embedded code copy of the OpenSSL
headers: include/openssl
http://wiki.debian.org/EmbeddedCodeCopies
Likewise for the other files in include/, they are all embedded code
copies, from Mozilla and scute.
esteidcerts:
Why do the certs need to be put in the ca-certificates db? Either they
should be in ca-certificates itself (unlikely), or they should not be
side-loaded into it via this package.
The debian/rules file looks a bit weird, seems like you install things
twice, once with dh_install and once manually.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: