Bug#702032: RFS: authprogs/0.1-1 [ITP #616126]
On Sat, Mar 2, 2013 at 5:47 AM, Alex Mestiashvili wrote:
> I am looking for a sponsor for my package "authprogs"
I don't intend to sponsor this but here is a review:
The patch combines multiple logical changes into one, please split it up.
The patch removes upstream copyright statements, license grants and
changelog bits. I'd suggest reverting those parts.
The patch adds three incorrectly spelled words (Standart, fro, debian).
I think /etc/authprogs would be a better place for the Debian config file.
Please get upstream to include the remainder of your patch.
It is not correct to build stuff in override_dh_auto_install, please
change that to override_dh_auto_build and install the manual page with
dh_installman.
Most of the README.Debian looks to be copies of stuff from elsewhere,
I would suggest dropping it. Anything remaining can be added to the
upstream README using a patch.
debian/changelog has UNRELEASED in it.
/tmp/authprogs.log is a very bad place for a log file.
Do the examples need to be in both the manual page and the example config file?
Please add a get-orig-source debian/rules target so anyone can
recreate the tarball.
Perl::Critic spews a lot of warnings about the upstream code, but I'm
not sure how many of them are valid.
One of the articles referenced by the package mentions it is version 0.5.
Automatic checks:
https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
lintian:
I: authprogs source: vcs-field-not-canonical
http://git.debian.org/?p=collab-maint/authprogs.git;a=summary
http://anonscm.debian.org/gitweb/?p=collab-maint/authprogs.git;a=summary
I: authprogs source: vcs-field-not-canonical
git://git.debian.org/collab-maint/authprogs.git
git://anonscm.debian.org/collab-maint/authprogs.git
P: authprogs: no-upstream-changelog
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: