[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#700360: RFS: openfst/1.3.3-1 -- weighted finite-state transducers library

Il 19/02/2013 21:22, Jakub Wilk ha scritto:
> * Giulio Paci <giuliopaci@gmail.com>, 2013-02-15, 03:34:
>>> As far as I can see, src/test/fst_test.h creates temporary files insecurely.
>> Relevant applications are now using private directory to store temporary files. As far as I can see, this solves the issue.
> It solves it for Debian, but the problem should be fixed upstream as well. Please notify them about the bug, if you haven't already.

I already forwarded the patch.
Upstream said they will evaluate this and other patches for inclusion in the next openfst release.

> You added:
> DEB_ROOT := $(abspath $(dir $(firstword $(MAKEFILE_LIST)))/..)
> But for build* and binary* target $(DEB_ROOT) is guaranteed to be equal to $(CURDIR). So just use the latter. :)

Using $(CURDIR) now. :-)

> I'd also use relative directories wherever possible (in this case, at least: mkdir -p, $(RM) -r), as they are less noisy in build logs.

And using just "tmpdir" as temporary directory instead of "$(DEB_ROOT)/tmpdir" or "$(CURDIR)/tmpdir".

Reply to: