[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#700567: RFS: burp/1.3.24-1



Hello,

thanks for maintaining this package, but I have some notes/questions:

1) Please, use compat-level 9, your package builds in this case fine and
removes "hardening-warnings" from lintian.

2) Changelog is the mess:
	a) A lot of "UNRELEASED"-words.
	b) Warnings due to bad formatting (use lintian for check).
	c) The last version in Debian is 1.3.8-1, but I cannot find it 	in
changelog. Moreover there are a lot of versions, which have never been
uploaded in Debian (1.3.18-1, for example). They should not be there.
	d) A lot of items in changelog, which should be in upstream-changelog,
but not in Debian one. Please, move them to a appropriate file.
Debian-changelog should contain only the Debian-stuff and changes.

3) Review your copyright-file according to a DEP-5. There are a lot of
"unneeded words". This file should be short and machine-readable.

4) Where is it possible to download the upstream-tarball of this
version? It is necessary to check md5-sums.

5) It is better to separate debian-folder and upstream-files and
maintain debian-stuff somewhere collab-maintain or in a group. It is
easier for reviewers/maintainers/DDs to do their job. But it is IMHO,
Actually, why VCS-browser link is commented?

The package seems in a good shape, but it really needs to be fixed
before uploading. Most of stuff is easy to fix.

Please, consider moving debian-stuff to a common place for easier
maintenance and collaboration.

Cheers,

Anton

On 02/14/2013 12:56 PM, Bas van den Dikkenberg wrote:
> Package: sponsorship-requests
> Severity: normal
> 
>   Dear mentors,
> 
>   I am looking for a sponsor for my package "burp"
> 
>  * Package name    : burp
>    Version         : 1.3.24-1
>    Upstream Author : [fill in name and email of upstream]
>  * URL             : http://burp.grke.net/
>  * License         : Graham Keeling <keeling@spamcop.net>
>    Section         : utils
> 
>   It builds those binary packages:
> 
>     burp  - Simple cross-platform network BackUp and Restore Program
>  burp-dbg   - debugging symbols for Burp
> 
>   To access further information about this package, please visit the following URL:
> 
>   http://mentors.debian.net/package/burp
> 
> 
>   Alternatively, one can download the package with dget using this command:
> 
>     dget -x http://mentors.debian.net/debian/pool/main/b/burp/burp_1.3.14-1.dsc
> 
>   More information about hello can be obtained from http://www.example.com.
> 
>   Changes since the last upload:
> 
>   * New upstream release version 1.3.24
>   * Bug fix for strip_vss/split_vss truncating backups of changed files on
>     Windows.
>   * Bug fix for autoupgrade failing on Windows if autoupgrade_dir has been
>     modified.
>   * Bug fix for listing backups created with split_vss=1.
>   * Bug fix for restoring uncompressed encrypted backups created with
>     split_vss=1.
>   * Bug fix for making backups with min_file_size and split_vss=1.
>   * Bug fix for Debian init do_stop() function from Peter Maloney.
>   * Bug fix for resuming backups where a file to patch has already been
>     hard linked into place. Also get the client to report a more helpful
>     message if any similar problem happens.
>   * Bug fix for signal handler race conditions.
>   * Bug fix for the forkchild child not exiting when execv fails.
>   * Changed the run_script() code to take an array.
>   * Added server_script_pre_notify and server_script_post_notify options.
>   * Rework the test script so that it can test Windows clients.
>   * Attempt a Windows signal handler to try to shut VSS down nicely on certain
>     signals, such as Ctrl-C.
>   * Include an example server side offsite rsync backup script. This is not
>     quite working properly, but it may still be useful.
>   * Big fix to stop Windows going to sleep during a backup, from Avi Rozen.
> 
> 
>   Regards,
>    Bas van den Dikkenberg
> 
> 


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: