Bug#699875: RFS: doodle/0.7.0-6 [ITA] -- Desktop Search Engine
On Wed, Feb 6, 2013 at 12:09 PM, Prach Pongpanich <prachpub@gmail.com> wrote:
> I am looking for a sponsor for my package "doodle"
It looks good in general. My quick review:
* Are you sure you want to upload to unstable during the freeze without
fixing RC bug? This is not wrong, but it may make RC bug fixing harder
in case one is found. I'd suggest uploading to experimental for the time
being.
* debian/patches/fix-hyphen-used-as-minus-sign.patch:
- Please consider prefixing the patch file name with number,
just like other patches.
- I guess this is from lintian. So, the Bug: header should not be necessary.
- Make sure to contact upstream after this.
* Please consider applying "wrap-and-sort" to debian/control file.
* Typo in changelog: ${misc:iPre-Depends} (extra 'i' before 'Pre-Depends')
* You may want to add your name to debian/* section in debian/copyright.
Regards,
--
Theppitak Karoonboonyanan
http://linux.thai.net/~thep/
Reply to: