Bug#686679: RFS: asn1c/0.9.21+dfsg-1 [ITP] -- ASN.1 compiler for C
On Sep 5, 2012, at 03:09, Arno Töll <arno@debian.org> wrote:
> tags 686679 + moreinfo
> thanks
>
> Hi Eugene,
>
> this is a review of your package.
Hello, Arno,
Thank you a lot for your time and explantations!
Please review my next upload at
http://mentors.debian.net/debian/pool/main/a/asn1c/asn1c_0.9.21.dfsg1-1.dsc
>
> * Do not install Lintian overrides for manpage-has-errors-from-man. The
> warning is legit, but of minor importance. Either fix it, or ignore it.
>
> * You are missing several uploads of asn1c which were in Debian at some
> point after Squeeze's version. You can find the latest package in [1].
> Consequently your version number is too low. 0.9.21.dfsg-1 was in Debian
> already in 2007 (uploaded 21 Jun 2007). Please use at very least
> 0.9.21.dfsg-5. Moreover, please import the delta of changes since then
> to your package.
>
I prefered .dfsg variant for consistent versioning. Repackaging original tarball
with removing PDF files leads to use of 'dfsg1' prefix so now full version is '0.9.21.dfsg1-1'.
> * There is a SVN repository for the packaging [2]. Please update that
> and add it to your control file [3]
>
> * In debian/rules, please remove the boilerplate blind text.
>
> * At your choice, either document how to build a repacked tarball (you
> need to remove the IETF files from the tarball as you probably know) in
> debian/README.source [4] or make a get-orig-source [5] target (or both).
>
Added VCS lines, fixed debian/rules and added
both README.source and get-orig-source target.
> * I couldn't find the source for the PDF files you install from doc/
> (the preferred form for modification that is). Please include it in your
> source package, or remove it while repacking the tarball.
It is correct. Upstream added pdf sources only in development branch.
For now I removed PDFs from a dfsg tarball.
>
> * Please add a DEP-3 header to your patches [6]. Also consider sending
> it upstream, unless you did already.
>
> * debian/copyright wrongly claims, the package would be subject to the
> BSD-2-clause license. Actually it is 3-clause.
Actually it was my mistake. It was a 2-clause license (according to COPYING file). Corrected a mistake.
> --
> with kind regards,
> Arno Töll
> IRC: daemonkeeper on Freenode/OFTC
> GnuPG Key-ID: 0x9D80F36D
>
---
Best regards,
Eugene Seliverstov
Reply to: