Hello, i've done some changes basing on your notes. > In your changelog, I'd add a ~exp1 or so to the version string. The > version you have now is perfect for unstable, but we're not going there Changed > The idea is I should be able to get back to where you were before. I tried to be a bit more verbose on the changelog > Usually I prefer lines not going over 80 chars in the debian/rules (see: > line 7) - you can wrap lines with a backslash (\) Uhm right, sorry about that > The line: > debhelper (>> 9.0.0) > should be changed to something like: > debhelper (>= 9) Fixed > In your xinetd.d/* files, you've got a mess of spaces (spaces all the > way to 80 chars) over all your curly braces Uhm true, done > You should consider adding a watch file :) I didn't think it was necessary since it looked like completely abandoned for years.. now someone new took over the developement so i guess a watch file is needed. Added. (i haven't packaged yet the new version because it would take some time to repatch it and it doesn't seem there were any major changes). > You should also consider DEP3 headers on 000007-CVE-2012-0862.patch Added subject and submitter > usr/sbin/xconv.pl <-- does this need to have the .pl extention for > legacy issues? Well i don't think changing a script's name is a good idea, there will probably be a few people upset about that! > etc/init.d/xinetd <-- You should add LSB headers They were there, the description was missing > usr/share/man/man5/xinetd.conf.5.gz <-- mispelling: avaliable available done, and changed some - into \- > You've also got a ton of FSSTND-dir-in-manual-page tags being emited, > the manpage might nice to fix :) Uhm i fail to understand what is this error about. > You've also got a possible-documentation-but-no-doc-base-registration > -- it might be seeing the debian/xinetd.org-FAQ.html being put in. > It'd be nice to register this with doc-base, but it's not the end of > the world. I tried to create a doc-base control file and install it and so on but i still get the warning. > (you should try running Lintian (with something like -IE --pedantic) > on the .changes *after* a build as well ;) ) Well i didn't know lintian could parse changes files too Let me know about the patches. I've uploaded the corrected version http://galileo.dmi.unict.it/~ltworf/xinetd/xinetd_2.3.14-8~exp1.dsc Thanks for the help. -- Salvo Tomaselli
Attachment:
signature.asc
Description: This is a digitally signed message part.