Bug#666243: RFS: peg/0.1.9-1 [ITP] -- recursive-descent parser generators for C
* Giulio Paci <giuliopaci@gmail.com>, 2012-07-19, 04:09:
The current version appears to be at:
http://mentors.debian.net/debian/pool/main/p/peg/peg_0.1.9-1.dsc
I updated it.
In addition to your recommendations I also changed section from "misc"
to "devel".
Very well.
The examples directory could act as a test suite. Please run it at
build time.
Done.
Please honour DEB_BUILD_OPTIONS=nocheck.
In my opinion, the long description is a bit too… long. I would remove
at least the citation, maybe something more, but I'm not sure what.
You might want to ask debian-l10n-english@ for an advice.
I removed most of the description, using *yacc packages as reference.
It seems more readable now.
That's better. You probably want to add a new line (escaped with a dot),
between "it." and "Unlike". Otherwise, they'll be considered a single
logical line.
I always feel uneasy about “Forwarded: not-needed” patches. I believe
parts of makefile_configuration.patch could be forwarded upstream, and
the rest of the logic could be moved to debian/rules
In this case "Forwarded: not-needed" means that upstream changed its
building scheme completely internally,
Fair enough.
-PREFIX = /usr/local
+PREFIX = /usr
Could be overridden in debian/rules.
As far as I know I should either move the binaries by hand or patch the
Makefile so that ?= is used in place of =. Is there any other solution?
You can keep "=":
":=" assignments can't be overridden;
"=" assignments can be overridden by "make VARIABLE=new-value".
"?=" assignments can be overridden by environment variables or by "make
VARIABLE=new-value".
%.peg-c : %.peg compile.c
- ./peg -o $@ $<
+ #./peg -o $@ $<
leg.o : leg.c
leg.c : leg.leg compile.c
- ./leg -o $@ $<
+ #./leg -o $@ $<
Hmm, why?
Because otherwise the compilation fails if the directory is clean, but
compile.c or .leg/.peg files have a more recent timestamp than the
target.
So that shouldn't normally happen, unless someone modified *.leg/*.peg
stuff. But in the latter case, the person wants either the .c files
updated, or at least be notified that this cannot be done automatically.
These instructions are only useful when developing peg and leg and are
safe to skip.
The great thing about free software, is that everybody can develop it,
including Debian users. So let's not make that harder than necessary. :)
--
Jakub Wilk
Reply to: