Bug#677935: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
Hi James,
James McDonald wrote:
> I am looking for a sponsor for my package "cwm"
>
> * Package name : cwm
> Version : 5.1-1
> Upstream Author : Christian Neukirchen <chneukirchen@gmail.com>
> * URL : https://github.com/chneukirchen/cwm
> * License : ISC
> Section : x11
>
> It builds those binary packages:
>
> cwm - Lightweight and efficient window manager for X11
I took a look at your package, here are a few comments:
- lintian reports the following warnings:
P: cwm source: unversioned-copyright-format-uri http://dep.debian.net/deps/dep5
I: cwm source: debian-watch-file-is-missing
P: cwm: no-upstream-changelog
P: cwm: no-homepage-field
I: cwm: hyphen-used-as-minus-sign usr/share/man/man5/cwmrc.5.gz:231
I: cwm: hyphen-used-as-minus-sign usr/share/man/man5/cwmrc.5.gz:245
- In debian/copyright, fgetln.c is licensed under the BSD-2-clause
license; and instead of repeating the ISC twice, you could factor it
out in its own standalone paragraph.
Also, the Source header should not point to one particular version.
Use the directory where all the tarballs are stored; but if you got
it from github, use that URL instead.
- In debian/control, why do you depend on dpkg-dev? The package seems
to build just fine without it.
You should also run wrap-and-sort from devscripts to get the
Build-Depends field wrapped and sorted.
And if you don't use a VCS for your packaging, you should remove
those commented-out lines.
Your long description repeats information provided by the short
description; see [1] for best practices. It could also be expanded a
bit.
[1] http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-desc
- You could use debhelper compat 9, that should take care of the
hardening flags for you.
And in debian/rules, you should remove the template comments.
- The README doesn't contain useful information for end-users, so you
shouldn't install it.
Cheers,
--
Benoît Knecht
Reply to: