Bug#676872: sponsorship-requests: RFS: python-minimock/1.2.7-1 -- simple library for Python mock objects
(I don't intend to sponsor this package.)
* Ben Finney <ben+debian@benfinney.id.au>, 2012-06-10, 17:17:
$ dget -x http://mentors.debian.net/debian/pool/main/p/python-minimock/python-minimock_1.2.7-1.dsc
Your debian/rules is odd. The "build-arch" target calls "dh build-arch",
so it's effectively no-op. However, the "binary-arch" target depends on
"install", which calls "dh install", which builds&install almost
everything. Shouldn't both "build-arch" and "binary-arch" be no-ops?
Upstream provides tests, please consider running them at build time.
+ Update copyright information.
Your copyright file says "2009-2011 Joshua Bronson", but I don't see any
such copyright statement in the upstream tarball.
License paragraphs of your copyright file are formatted in an unusual
way. Only lines containing a full stop indented by exactly one space
denote blank lines. A full stop indented by more than one space (like in
your case) means a verbatim dot.
The package FTBFS if built twice in a row:
| dpkg-source -b python-minimock-1.2.7
| dpkg-source: info: using source format `3.0 (quilt)'
| dpkg-source: info: building python-minimock using existing ./python-minimock_1.2.7.orig.tar.gz
| dpkg-source: warning: file python-minimock-1.2.7/MiniMock.egg-info/SOURCES.txt has no final newline (either original or modified version)
| dpkg-source: info: local changes detected, the modified files are:
| python-minimock-1.2.7/MiniMock.egg-info/PKG-INFO
| python-minimock-1.2.7/MiniMock.egg-info/SOURCES.txt
| dpkg-source: info: you can integrate the local changes with dpkg-source --commit
| dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/python-minimock_1.2.7-1.diff.zzEZVx
| dpkg-buildpackage: error: dpkg-source -b python-minimock-1.2.7 gave error exit status 2
--
Jakub Wilk
Reply to: