Re: Bug#676643: RFS: x2goclient/3.99.2.1-2
On Fri, Jun 08, 2012 at 11:03:31PM +0200, Mike Gabriel wrote:
> Hi all (esp. Bart, who already took a look at the formerly uploaded package),
>
> On Fr 08 Jun 2012 15:39:53 CEST Mike Gabriel wrote:
>
> > * Package name : x2goclient
> > Version : 3.99.2.1-2
> > Upstream Author : Oleksandr Shneyder
> > * URL : http://wiki.x2go.org
> > * License : GPL-2+
> > Section : x11
> >
>
> I have re-uploaded the package after I had seen your comments on mentors.
>
> 1. changing a previous changelog entry...
>
> I am not sure what you meant by that.
I read "modifies previous entries in changelog" in my notes for x2goclient
uploaded to mentors on 2012-06-08 13:20, but when I look at the package again I
see no such modifications, so now I'm not sure anymore what I meant.
> Did you refer to a commit in
> the Vcs-Git
> of x2goclient on Alioth?
No, I hadn't looked at that.
> Yes there I had a commit that was correcting a typo
> in an already released version. That has been removed now.
Correcting a typo is no problem at all, in my opinion.
>
> 2. lintian-overrides
> W: x2goplugin: hardening-no-fortify-functions
> usr/lib/mozilla/plugins/libx2goplugin.so
> W: x2goclient: hardening-no-fortify-functions usr/bin/x2goclient
>
> -> if I understood your request correctly you recommend / ask for not
> overriding these lintian warnings due to the current state of the detection
> code? For now, I have removed the lintian-overrides for those from
> the package
> again.
Yes I recommend to not override false positives currently produces by lintian.
I think that lintian should be fixed to no longer produce false positives
instead.
>
> Do you think you could take another look?
Yes I'll take another look.
>
> x2goclient (3.99.2.1-2) unstable; urgency=low
>
> * Fix patch: 001_hardening-x2goclient.patch, add patch description.
> * Add patch: 002_remove-encoding-from-desktop-entry.patch, encoding keys in
> .desktop files have become deprecated (FreeDesktop.org).
> * Add patch: 003_fix-spelling-error-authentication.patch, fix the spelling
> of the word authentication.
> * Also add upstream changelog to bin:package x2goplugin.
> * Do not ship html version of man page anymore.
> * Drop lintian overrides (hardening-no-fortify-functions) again due
> to recommendation/request from Bart Martens <bartm@debian.org>.
>
> -- Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
> Fri, 08 Jun 2012 22:10:10 +0200
Note that you quoted 3.99.2.1-2 but also 3.99.2.1-1 is not yet in Debian.
Maybe you want to merge 3.99.2.1-2 and 3.99.2.1-1 into just 3.99.2.1-1 but that
is optional, in my opinion. Anyhow, I'm comparing your package at mentors with
3.99.2.0-1.
Regards,
Bart Martens
Reply to: