Bug#675532: RFS: bilibop/0.1 (ITP #675467)
Hi,
bilibop project wrote (02 Jun 2012 00:07:22 GMT) :
> I am looking for a sponsor for my package "bilibop"
Here is a first, quick review.
First of all, this is great work. In case this is your first Debian
packaging work, as you seem to indicate in the ITP bug, then congrats!
The whole thing is arch:all, but some shell functions require a Linux
kernel shouldn't bilibop-common have a versioned dependency on Linux
kernel >= 2.6.37 (needed by backing_file_from_loop), and be
arch:linux-any instead?
Quotes such as in "« disk »" are no international symbols, and I've
seen English native speakers misinterpret those.
You want an URI to a versioned copyright format:
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
(catched by lintian --pedantic).
Any Vcs-Git / Vcs-Browser field? If you have none ready, I suggest
setting up a Git repository in collab-maint on Alioth.
Given the Maintainer is a collective email address, we need at least
one human listed in the Uploaders: field (Debian Policy §3.3) -- note
that this field has nothing to do with who actually sponsors the
uploads; either put yourself, a co-maintainer, or the first sponsor if
they are willing to take the responsibility to act as co-maintainers.
Why does bilibop-common's postinst and postrm run update-initramfs?
The debian/changelog entry must close the ITP bug.
The debian/rules header about "Sample debian/rules that uses
debhelper" should be removed.
Why the need to disable override_dh_pysupport by hand?
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
Reply to: